[FIX] loyalty: incomplete migration

Author: hbrunn

docsource/modules180-190.rst

@@ -698,7 +698,7 @@ Module coverage 18.0 -> 19.0
 +---------------------------------------------------+----------------------+-------------------------------------------------+
 | link_tracker                                      |                      |No DB layout changes.                            |
 +---------------------------------------------------+----------------------+-------------------------------------------------+
-| loyalty                                           |                      |                                                 |
+| loyalty                                           |Done                  |                                                 |
 +---------------------------------------------------+----------------------+-------------------------------------------------+
 | lunch                                             |                      |                                                 |
 +---------------------------------------------------+----------------------+-------------------------------------------------+

openupgrade_scripts/scripts/loyalty/19.0.1.0/post-migration.py

@@ -1,13 +1,20 @@
 from openupgradelib import openupgrade
 
 
-@openupgrade.migrate()
-def migrate(env, version):
+def fix_template_lang(env):
     """Reset "lang" field for these records, as they were set in previous
     version in XML, but not in this one, and Odoo doesn't reset non present
     fields.
+    The templates are not marked as noupdate, so this change is not caught by
+    upgrade_analysis
     """
     for xmlid in ("mail_template_gift_card", "mail_template_loyalty_card"):
         template = env.ref(f"loyalty.{xmlid}", False)
         if template:
             template.lang = False
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    openupgrade.load_data(env, "loyalty", "19.0.1.0/noupdate_changes.xml")
+    fix_template_lang(env)

openupgrade_scripts/scripts/loyalty/19.0.1.0/upgrade_analysis_work.txt

@@ -0,0 +1,7 @@
+---Models in module 'loyalty'---
+---Fields in module 'loyalty'---
+loyalty      / loyalty.reward           / tax_ids (many2many)           : DEL relation: account.tax
+
+# NOTHING TO DO
+
+---XML records in module 'loyalty'---