[19.0][MIG]: website_sale_product_brand by Alexgars73 · Pull Request #1181 · OCA/e-commerce

Alexgars73 · 2026-03-16T11:44:37Z

Added to prevent the product brand from being displayed in website filters if the brand does not have any published products.

Reyes4711-S73

LGTM
Functional review OK

OCA Transbot updated translations from Transifex

[ADD][website_sale_wishlist] Wishlist for your online shop. Allow your visitors and users to wishlist your products and have a shortcut for seeing them. Wishlisted products are stored in the session for public users, and linked to the user if s/he is logged in. OCA Transbot updated translations from Transifex

OCA Transbot updated translations from Transifex

[UPD] Update website_sale_product_brand.pot [UPD] README.rst Translated using Weblate (Persian) Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-11.0/e-commerce-11.0-website_sale_product_brand Translate-URL: https://translation.odoo-community.org/projects/e-commerce-11-0/e-commerce-11-0-website_sale_product_brand/fa/

website_sale_product_brand 12.0.1.1.0

[UPD] Update website_sale_product_brand.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_brand Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_brand/ pre-commit update

website_sale_product_brand 13.0.1.1.1

Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_brand Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_brand/pt_BR/

Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_brand Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_brand/nl/

Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_brand Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_brand/ca/

TT31863

Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-14.0/e-commerce-14.0-website_sale_product_brand Translate-URL: https://translation.odoo-community.org/projects/e-commerce-14-0/e-commerce-14-0-website_sale_product_brand/es_AR/

Before this patch, images were deformed if they didn't meet precise proportions. TT34753

- Allow to hide brands from the e-commerce - Added brand configuration menu for the case `sale_management` app isn't installed. - Updated README

OCA-git-bot · 2026-03-21T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Reyes4711-S73 · 2026-03-23T06:46:34Z

@OCA/e-commerce-maintainers Please, can you review/merge this PR?

Ricardoalso

Could you squash commits following the rules defined in https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests ? 🙏

Ricardoalso · 2026-05-04T11:57:02Z

@@ -8,3 +8,15 @@ class ProductBrand(models.Model):
    _inherit = ["product.brand", "website.published.mixin"]

    is_published = fields.Boolean(default=True)


is_published is already defined in website.published.mixin

@Ricardoalso I think wants to add the default=True to the field. I deleted this and added _default_is_published to True

Ricardoalso · 2026-05-04T11:58:54Z

+        brand_rec = (
+            b_obj.sudo()
+            .search(domain)
+            .filtered(lambda x: x.published_products_count > 0)


published_products_count > 0 can be added to the domain

@Ricardoalso i think not it's a compute

Indeed, it's a computed and stored field. Not searchable as-is 👍

This leads me to question the utility of filtering on published_products_count > 0 🤔

It wasn't the case in previous versions, and doing so will exclude brands from the website even if we want to display a landing (for example) page for brands we have but have not yet configured any product.template for. I am currently working on such improvements (product brand landing page), and with this business case it makes more sense to display all brands even if no product.template is associated. What do you think? Did you have any specific technical or business need or issue that led you to implement this filter on published_products_count > 0?

Thanks in advance for your input 🙏

I opened a PR #1204 with the feature "brand landing page"

@Ricardoalso We were looking into it and saw the need to make that improvement because I think it makes perfect sense; why publish a brand if there isn't an active product yet?

It can make sense in the current state indeed. I will add a configuration in my PR where I add the brand "landing pages" feature

Thanks for you feedback

Alexgars73 · 2026-05-04T15:39:21Z

@Ricardoalso I'm not entirely clear on which commits should be squashed.

Ricardoalso · 2026-05-05T11:33:37Z

@Ricardoalso I'm not entirely clear on which commits should be squashed.

I was thinking about the commits generated by bots or Weblate
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

I see at least 4 commits oca-* bot authored; for example 0497497

And all the weblate translation commits are related to the module website_sale_product_brand [MIG] website_sale_product_brand: Migration to version 18.0. You can fixup all commits below it

TT54392

…brand

Alexgars73 · 2026-05-11T07:26:58Z

@Ricardoalso done! Could you check it now?

Ricardoalso · 2026-05-11T07:46:28Z

@Ricardoalso done! Could you check it now?

Thanks for the rebase @Alexgars73 🙏

Could you check my comment #1181 (comment)?

…ct_brand [19.0][MIG]: website_sale_product_brand

yankinmax · 2026-05-11T15:12:06Z

+    def _compute_published_products_count(self):
+        for brand in self:
+            brand.published_products_count = self.env["product.template"].search_count(
+                [
+                    ("product_brand_id", "=", brand.id),
+                    ("website_published", "=", True),
+                ]
+            )


Maybe worth to reuse the same way products are counted in the product_brand module for performance reason:
https://github.com/OCA/brand/blob/0cb061b0b1014d201b27d3d3c44623f37725ce0f/product_brand/models/product_brand.py#L32-L42
Something like:

@api.depends("product_ids") def _compute_published_products_count(self): product_model = self.env["product.template"] groups = product_model._read_group( [("product_brand_id", "in", self.ids), ("website_published", "=", True)], ["product_brand_id"], ["product_brand_id:count"], ) data = {group[0].id: group[1] for group in groups} for brand in self: brand.published_products_count = data.get(brand.id, 0)

vvrossem

Thank you for your contribution 🎉

vvrossem · 2026-05-14T11:23:54Z

+import {patch} from "@web/core/utils/patch";
+
+patch(WebsiteSale.prototype, {
+    onChangeAttribute(ev) {


I'd add some comments explaining what this function does

vvrossem · 2026-05-14T11:25:11Z

+                    "login": login,
+                    "password": login,
+                    "email": "portal_brand@example.com",
+                    "group_ids": [(6, 0, [cls.env.ref("base.group_portal").id])],


Suggested change

"group_ids": [(6, 0, [cls.env.ref("base.group_portal").id])],

"group_ids": [Command.set([cls.env.ref("base.group_portal").id])],

Alexgars73 force-pushed the 19.0-mig-website_sale_product_brand branch 5 times, most recently from 7c14e54 to af31ea6 Compare March 16, 2026 15:24

Reyes4711-S73 approved these changes Mar 16, 2026

View reviewed changes

miguel-S73 approved these changes Mar 16, 2026

View reviewed changes

OCA-git-bot added the approved label Mar 16, 2026

MeetSCS and others added 22 commits March 17, 2026 09:14

[IMP]Changed name of module.

633ec66

[MIG]Migrated shop_by_brand module in v9.

35bc8c3

OCA Transbot updated translations from Transifex

[FIX] website_sale_product_brand: Page not found in category pagination

919c0a4

OCA Transbot updated translations from Transifex

[MIG] website_sale_product_brand: Migration to v12.0

efc36c2

[IMP] website_sale_product_brand: Better website view

7c620ac

website_sale_product_brand 12.0.1.1.0

[IMP] website_sale_product_brand: black, isort

4f68126

[FIX] website_sale_product_brand: Fix _get_search_domain parameters

6633fca

website_sale_product_brand 13.0.1.1.1

Added translation using Weblate (Dutch)

c6e5a3c

Translated using Weblate (Dutch)

c387a22

Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_brand Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_brand/nl/

Translated using Weblate (Catalan)

1d4438f

Currently translated at 100.0% (5 of 5 strings) Translation: e-commerce-13.0/e-commerce-13.0-website_sale_product_brand Translate-URL: https://translation.odoo-community.org/projects/e-commerce-13-0/e-commerce-13-0-website_sale_product_brand/ca/

[IMP] website_sale_product_brand: black, isort, prettier

ee152b7

[MIG] website_sale_product_brand: Migration to 14.0

3e84213

TT31863

[MIG] website_sale_product_brand: Migration to 15.0

d03ea67

[FIX] website_sale_product_brand: image proportions

00d52be

Before this patch, images were deformed if they didn't meet precise proportions. TT34753

[IMP] website_sale_product_brand: add website.published.mixin

daa014f

- Allow to hide brands from the e-commerce - Added brand configuration menu for the case `sale_management` app isn't installed. - Updated README

[IMP] website_sale_product_brand: Use options to define the brand

de57e89

[MIG] website_sale_product_brand: Migration to 16.0

e1f4d1b

Alexgars73 force-pushed the 19.0-mig-website_sale_product_brand branch 8 times, most recently from bffb12b to 17cabcf Compare March 17, 2026 11:51

OCA-git-bot added the ready to merge label Mar 21, 2026

Alexgars73 force-pushed the 19.0-mig-website_sale_product_brand branch from 17cabcf to 8799077 Compare March 24, 2026 10:46

Alexgars73 force-pushed the 19.0-mig-website_sale_product_brand branch from 8799077 to c9d1af4 Compare March 31, 2026 13:36

Ricardoalso reviewed May 4, 2026

View reviewed changes

Alexgars73 force-pushed the 19.0-mig-website_sale_product_brand branch from c9d1af4 to c0eb27e Compare May 4, 2026 15:38

OCA-git-bot added series:19.0 mod:website_sale_product_brand Module website_sale_product_brand labels May 4, 2026

Alexgars73 force-pushed the 19.0-mig-website_sale_product_brand branch from c0eb27e to 1140edc Compare May 4, 2026 15:45

Ricardoalso mentioned this pull request May 8, 2026

[19.0][IMP] website_sale_product_brand: configurable brand landing pages #1204

Draft

pilarvargas-tecnativa and others added 3 commits May 11, 2026 09:24

[MIG] website_sale_product_brand: Migration to version 18.0

961d1c2

TT54392

[IMP] website_sale_product_brand: merged website_sale_filter_product_…

9ad7a58

…brand

[MIG] website_sale_product_brand: Migration to 19.0

0464388

Alexgars73 force-pushed the 19.0-mig-website_sale_product_brand branch from 1140edc to 0464388 Compare May 11, 2026 07:26

Ricardoalso added a commit to camptocamp/e-commerce that referenced this pull request May 11, 2026

Merge pull request OCA#1181 from Studio73/19.0-mig-website_sale_produ…

ebecac3

…ct_brand [19.0][MIG]: website_sale_product_brand

yankinmax reviewed May 11, 2026

View reviewed changes

vvrossem approved these changes May 14, 2026

View reviewed changes

		@@ -8,3 +8,15 @@ class ProductBrand(models.Model):
		_inherit = ["product.brand", "website.published.mixin"]

		is_published = fields.Boolean(default=True)

	"group_ids": [(6, 0, [cls.env.ref("base.group_portal").id])],
	"group_ids": [Command.set([cls.env.ref("base.group_portal").id])],

Uh oh!

Conversation

Alexgars73 commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reyes4711-S73 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 21, 2026

Uh oh!

Reyes4711-S73 commented Mar 23, 2026

Uh oh!

Ricardoalso left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Alexgars73 commented May 4, 2026

Uh oh!

Ricardoalso commented May 5, 2026

Uh oh!

Alexgars73 commented May 11, 2026

Uh oh!

Ricardoalso commented May 11, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vvrossem left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Alexgars73 commented Mar 16, 2026 •

edited

Loading

Reyes4711-S73 left a comment •

edited

Loading