[FIX] website_sale_product_reference_displayed: fix snippet filter signatures#1184
Merged
OCA-git-bot merged 2 commits intoJun 5, 2026
Merged
Conversation
…gnatures Replace positional `context` argument with `**kwargs` in all `_get_products_*` handler overrides to match the core Odoo signature. The old signature caused a TypeError when `product_template_id` was passed as a keyword argument (e.g. on the alternative products filter).
Contributor
Author
|
FYI @kobros-tech |
Contributor
|
Thanks, can we work on the tests? I am happy to help with that if you need. |
Contributor
Author
@kobros-tech thanks, no need, I will prepare the tests. |
Contributor
Author
|
@kobros-tech done. Could you review, please? |
ivantodorovich
approved these changes
Jun 5, 2026
ivantodorovich
left a comment
ivantodorovich
left a comment
Contributor
There was a problem hiding this comment.
Thanks!
/ocabot merge patch
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 4c1a125. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace positional
contextargument with**kwargsin all_get_products_*handler overrides to match the core Odoo signature. The old signature caused a TypeError whenproduct_template_idwas passed as a keyword argument (e.g. on the alternative products filter).