Skip to content

[19.0][ADD] website_sale_product_inquiry#1202

Open
JasminSForgeFlow wants to merge 1 commit into
OCA:19.0from
ForgeFlow:19.0-add-website_sale_product_inquiry
Open

[19.0][ADD] website_sale_product_inquiry#1202
JasminSForgeFlow wants to merge 1 commit into
OCA:19.0from
ForgeFlow:19.0-add-website_sale_product_inquiry

Conversation

@JasminSForgeFlow
Copy link
Copy Markdown

@JasminSForgeFlow JasminSForgeFlow commented May 6, 2026

This module adds a new button on the product page to inquire about the product. On submitting the inquiry form, it will create a lead with details.

@ForgeFlow

@OCA-git-bot OCA-git-bot added series:19.0 mod:website_sale_product_inquiry Module website_sale_product_inquiry labels May 6, 2026
@JasminSForgeFlow
Copy link
Copy Markdown
Author

JasminSForgeFlow commented May 6, 2026

FYI, tests are failing because of the following warning from the module website_sale_checkout_skip_payment

2026-05-06 06:49:46,154 306 WARNING odoo odoo.addons.website_sale_checkout_skip_payment.tests.test_checkout_skip_payment.WebsiteSaleHttpCase.test_ui_website: Killing chrome descendants-or-self of 323: 5 remaining
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)

AaronHForgeFlow
AaronHForgeFlow approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok! 👍

Comment thread website_sale_product_inquiry/models/crm_lead.py
class CrmLead(models.Model):
_inherit = "crm.lead"

product_id = fields.Many2one(
Copy link
Copy Markdown

@AaronHForgeFlow AaronHForgeFlow May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if product_id is "too generic" for the purpose we are doing in here.

@JasminSForgeFlow JasminSForgeFlow changed the title [ADD] website_sale_product_inquiry [19.0][ADD] website_sale_product_inquiry May 6, 2026
@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-add-website_sale_product_inquiry branch from fa0eaf3 to af133df Compare May 7, 2026 08:43
MarinaAForgeFlow
MarinaAForgeFlow reviewed May 12, 2026
View reviewed changes
Comment thread website_sale_product_inquiry/views/templates.xml
id="inquiryContactName"
name="contact_name"
required="required"
placeholder="Your name"
Copy link
Copy Markdown

@MarinaAForgeFlow MarinaAForgeFlow May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also pre-fill the name based on the logged in user name?

Copy link
Copy Markdown
Author

@JasminSForgeFlow JasminSForgeFlow May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, also prefill the company name and phone based on the login user.

@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-add-website_sale_product_inquiry branch from af133df to ed61277 Compare May 13, 2026 04:09
@MiquelRForgeFlow
Copy link
Copy Markdown

MiquelRForgeFlow commented May 14, 2026

Tests failing.

@JasminSForgeFlow
Copy link
Copy Markdown
Author

JasminSForgeFlow commented May 14, 2026

Tests failing.

tests are failing because of the following warning from the module website_sale_checkout_skip_payment

2026-05-06 06:49:46,154 306 WARNING odoo odoo.addons.website_sale_checkout_skip_payment.tests.test_checkout_skip_payment.WebsiteSaleHttpCase.test_ui_website: Killing chrome descendants-or-self of 323: 5 remaining
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)
- chrome (zombie)

@MiquelRForgeFlow
Copy link
Copy Markdown

MiquelRForgeFlow commented May 14, 2026

tests are failing because of the following warning from the module website_sale_checkout_skip_payment

Could you do another PR solving it?

DavidJForgeFlow
DavidJForgeFlow reviewed May 18, 2026
View reviewed changes
Comment thread website_sale_product_inquiry/views/templates.xml
id="inquiryPhone"
name="phone"
placeholder="Your phone number"
t-att-value="(website.env.user.partner_id.phone or website.env.user.partner_id.mobile) if not website.env.user._is_public() else None"
Copy link
Copy Markdown

@DavidJForgeFlow DavidJForgeFlow May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove mobile as it is not a standard field for res.partner (added by partner_mobile OCA module)

@DavidJForgeFlow DavidJForgeFlow force-pushed the 19.0-add-website_sale_product_inquiry branch from ed61277 to e62d7de Compare May 18, 2026 13:34
@JasminSForgeFlow
Copy link
Copy Markdown
Author

JasminSForgeFlow commented May 19, 2026

tests are failing because of the following warning from the module website_sale_checkout_skip_payment

Could you do another PR solving it?

#1215

@JasminSForgeFlow JasminSForgeFlow force-pushed the 19.0-add-website_sale_product_inquiry branch from e62d7de to 115c96d Compare May 19, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@DavidJForgeFlow DavidJForgeFlow DavidJForgeFlow left review comments

@MarinaAForgeFlow MarinaAForgeFlow MarinaAForgeFlow left review comments

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mod:website_sale_product_inquiry Module website_sale_product_inquiry series:19.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JasminSForgeFlow @MiquelRForgeFlow @AaronHForgeFlow @DavidJForgeFlow @MarinaAForgeFlow @OCA-git-bot