[IMP] edi_mail_import_oca: Pass verification logic to constrain.

Remove unnecessary sudo

Author: etobella

edi_mail_import_oca/models/edi_exchange_record.py

@@ -7,7 +7,6 @@
 import re
 
 from odoo import api, models
-from odoo.exceptions import UserError
 
 _logger = logging.getLogger(__name__)
 
@@ -21,10 +20,6 @@ def message_new(self, msg_dict, custom_values=None):
             msg_dict,
             custom_values=custom_values,
         )
-        if record.type_id.direction != "input":
-            raise UserError(
-                self.env._("Received email for non-incoming exchange type.")
-            )
         if record.type_id.mail_as_attachment:
             new_message_dict = msg_dict.copy()
             attachments = new_message_dict.pop("attachments", [])

edi_mail_import_oca/models/edi_exchange_type.py

@@ -2,7 +2,8 @@
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 import ast
 
-from odoo import fields, models
+from odoo import api, fields, models
+from odoo.exceptions import ValidationError
 
 
 class EdiExchangeType(models.Model):
@@ -13,11 +14,19 @@ class EdiExchangeType(models.Model):
         string="Import Email as an Attachment",
     )
 
+    @api.constrains("direction", "alias_id.alias_domain", "alias_id.alias_name")
+    def _check_mail_configuration(self):
+        for record in self:
+            if record.direction != "input" and record.alias_email:
+                raise ValidationError(
+                    self.env._(
+                        "You cannot have a receiving email for a non-incoming type."
+                    )
+                )
+
     def _alias_get_creation_values(self):
         values = super()._alias_get_creation_values()
-        values["alias_model_id"] = (
-            self.env["ir.model"].sudo()._get("edi.exchange.record").id
-        )
+        values["alias_model_id"] = self.env["ir.model"]._get("edi.exchange.record").id
         if self.id:
             values["alias_defaults"] = defaults = ast.literal_eval(
                 self.alias_defaults or "{}"

edi_mail_import_oca/tests/test_mail_import_oca.py

@@ -2,6 +2,7 @@
 
 import json
 
+from odoo.exceptions import ValidationError
 from odoo.tests import tagged
 
 from odoo.addons.mail.tests.common import MailCommon
@@ -38,6 +39,15 @@ def setUpClass(cls):
             }
         )
 
+    def test_constraint(self):
+        with self.assertRaises(ValidationError):
+            self.exchange_type.direction = "output"
+
+    def test_constraint_no_error_on_no_alias(self):
+        self.exchange_type.alias_name = False
+        self.exchange_type.direction = "output"
+        self.assertFalse(self.exchange_type.alias_email)
+
     def test_import_full(self):
         self.assertTrue(self.exchange_type.alias_email)
         self.exchange_type.mail_as_attachment = True