[18.0][FIX] edi_storage_oca: raise error if file is missing when performing receive#274
Open
ArnauCForgeFlow wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the FTP read fails on receive (connection drop, missing file), the exchange record was wrongly transitioning to "input_received" with an empty file, because "_get_remote_file"" was silently swallowing the error and returning None. Fixed by raising on receive instead, so the record correctly goes to "input_receive_error".
As a side effect, since the record sat in "input_received" with no file, every run of the processing cron tried to process it, failed because the file was missing, and queued a new job. This led to an ever-growing pile of failing queue jobs for the same record.