[MIG] document_page_approval: Migration to 19.0

BhaveshHeliconia · BhaveshHeliconia · commit 930b3d0634e7 · 2026-03-13T10:44:44.000+05:30
diff --git a/document_page_approval/README.rst b/document_page_approval/README.rst
@@ -21,13 +21,13 @@ Document Page Approval
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fknowledge-lightgray.png?logo=github
-    :target: https://github.com/OCA/knowledge/tree/18.0/document_page_approval
+    :target: https://github.com/OCA/knowledge/tree/19.0/document_page_approval
     :alt: OCA/knowledge
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_approval
+    :target: https://translation.odoo-community.org/projects/knowledge-19-0/knowledge-19-0-document_page_approval
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/knowledge&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/knowledge&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -68,7 +68,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/knowledge/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/knowledge/issues/new?body=module:%20document_page_approval%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/knowledge/issues/new?body=module:%20document_page_approval%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -119,6 +119,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/knowledge <https://github.com/OCA/knowledge/tree/18.0/document_page_approval>`_ project on GitHub.
+This module is part of the `OCA/knowledge <https://github.com/OCA/knowledge/tree/19.0/document_page_approval>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
diff --git a/document_page_approval/__manifest__.py b/document_page_approval/__manifest__.py
@@ -3,7 +3,7 @@
 
 {
     "name": "Document Page Approval",
-    "version": "18.0.1.1.0",
+    "version": "19.0.1.0.0",
     "author": "Savoir-faire Linux, Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/knowledge",
     "license": "AGPL-3",
diff --git a/document_page_approval/models/document_page.py b/document_page_approval/models/document_page.py
@@ -109,7 +109,7 @@ def can_user_approve_this_page(self, user):
         if not self.approver_group_ids:
             return True
         # to approve, user must belong to any of the approver groups
-        return len(user.groups_id & self.approver_group_ids) > 0
+        return len(user.group_ids & self.approver_group_ids) > 0
 
     def _compute_has_changes_pending_approval(self):
         history = self.env["document.page.history"]
diff --git a/document_page_approval/models/document_page_history.py b/document_page_approval/models/document_page_history.py
@@ -64,8 +64,9 @@ def action_to_approve(self):
         for rec in self:
             if rec.state != "draft":
                 raise UserError(
-                    self.env._("Can't approve pages in '%(state)s' state.")
-                    % {"state": rec.state}
+                    self.env._(
+                        "Can't approve pages in '%(state)s' state.", state=rec.state
+                    )
                 )
             if not (rec.am_i_owner or rec.am_i_approver):
                 raise UserError(
@@ -79,7 +80,7 @@ def action_to_approve(self):
                 rec.write({"state": "to approve"})
                 guids = [g.id for g in rec.page_id.approver_group_ids]
                 users = self.env["res.users"].search(
-                    [("groups_id", "in", guids), ("groups_id", "in", approver_gid.id)]
+                    [("group_ids", "in", guids), ("group_ids", "in", approver_gid.id)]
                 )
                 rec.message_subscribe(partner_ids=users.mapped("partner_id").ids)
                 rec.message_post_with_source(template)
@@ -91,28 +92,23 @@ def action_approve(self):
         """Set a change request as approved."""
         for rec in self:
             if rec.state not in ["draft", "to approve"]:
-                raise UserError(
-                    self.env._("Can't approve page in '%(state)s' state.")
-                    % {"state": rec.state}
-                )
+                self.env._("Can't approve page in '%(state)s' state.", state=rec.state)
             if not rec.am_i_approver:
+                groups_str = ", ".join(
+                    g.display_name for g in rec.page_id.approver_group_ids
+                )
                 raise UserError(
                     self.env._(
-                        "You are not authorized to do this.\n"
-                        "Only approvers with these groups can approve this: %(groups)s"
+                        "Only approvers with these groups can approve this: %(groups)s",
+                        groups=groups_str,
                     )
-                    % {
-                        "groups": ", ".join(
-                            g.display_name for g in rec.page_id.approver_group_ids
-                        )
-                    }
                 )
 
             # Update state
             rec.write(
                 {
                     "state": "approved",
-                    "approved_date": fields.datetime.now(),
+                    "approved_date": fields.Datetime.now(),
                     "approved_uid": self.env.uid,
                 }
             )
@@ -121,14 +117,17 @@ def action_approve(self):
             # Notify state change
             rec.message_post(
                 subtype_xmlid="mail.mt_comment",
-                body=self.env._("Change request has been approved by %(user)s.")
-                % {"user": self.env.user.name},
+                body=self.env._(
+                    "Change request has been approved by %(user)s.",
+                    user=self.env.user.name,
+                ),
             )
             # Notify followers a new version is available
             rec.page_id.message_post(
                 subtype_xmlid="mail.mt_comment",
-                body=self.env._("New version of the document {} approved.").format(
-                    rec.page_id.name
+                body=self.env._(
+                    "New version of the document %(name)s approved.",
+                    name=rec.page_id.name,
                 ),
             )
 
@@ -139,12 +138,10 @@ def action_cancel(self):
             rec.message_post(
                 subtype_xmlid="mail.mt_comment",
                 body=self.env._(
-                    "Change request <b>%(name)s</b> has been cancelled by %(user)s."
-                )
-                % {
-                    "name": rec.display_name,
-                    "user": self.env.user.name,
-                },
+                    "Change request <b>%(name)s</b> has been cancelled by %(user)s.",
+                    name=rec.display_name,
+                    user=self.env.user.name,
+                ),
             )
 
     def action_cancel_and_draft(self):
diff --git a/document_page_approval/security/document_page_security.xml b/document_page_approval/security/document_page_security.xml
@@ -2,7 +2,6 @@
 <odoo>
     <record id="group_document_approver_user" model="res.groups">
         <field name="name">Approver</field>
-        <field name="category_id" ref="document_knowledge.module_category_knowledge" />
         <field
             name="implied_ids"
             eval="[(4, ref('document_page.group_document_editor'))]"
diff --git a/document_page_approval/static/description/index.html b/document_page_approval/static/description/index.html
@@ -374,7 +374,7 @@ <h1>Document Page Approval</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:ad1f0f3942df59076ffe4ebdf9ba440842d2792c5a1932cfd434ce9f20448e87
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/knowledge/tree/18.0/document_page_approval"><img alt="OCA/knowledge" src="https://img.shields.io/badge/github-OCA%2Fknowledge-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/knowledge-18-0/knowledge-18-0-document_page_approval"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/knowledge&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/knowledge/tree/19.0/document_page_approval"><img alt="OCA/knowledge" src="https://img.shields.io/badge/github-OCA%2Fknowledge-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/knowledge-19-0/knowledge-19-0-document_page_approval"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/knowledge&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>This module adds a workflow to approve page modifications and show the
 approved version by default.</p>
 <p><strong>Table of contents</strong></p>
@@ -418,7 +418,7 @@ <h2><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/knowledge/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/knowledge/issues/new?body=module:%20document_page_approval%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/knowledge/issues/new?body=module:%20document_page_approval%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -471,7 +471,7 @@ <h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/knowledge/tree/18.0/document_page_approval">OCA/knowledge</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/knowledge/tree/19.0/document_page_approval">OCA/knowledge</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
diff --git a/document_page_approval/tests/test_document_page_approval.py b/document_page_approval/tests/test_document_page_approval.py
@@ -1,4 +1,3 @@
-from odoo import Command
 from odoo.exceptions import UserError
 from odoo.tests import new_test_user
 
@@ -11,23 +10,44 @@ def setUpClass(cls):
         super().setUpClass()
         cls.page_obj = cls.env["document.page"]
         cls.history_obj = cls.env["document.page.history"]
+        cls.category_model = cls.env["document.page"]
 
-        # Demo Data
-        cls.category1 = cls.env.ref("document_page.demo_category1")
-        cls.page1 = cls.env.ref("document_page.demo_page1")
-
-        # Create test user without groups first
+        # Create test users
+        cls.manager_user = new_test_user(
+            cls.env,
+            login="test_manager",
+            groups="document_page.group_document_manager",
+            name="Test Manager",
+            email="manager@example.com",
+        )
         cls.user2 = new_test_user(
             cls.env,
             login="test-user2",
-            groups="document_page_approval.group_document_approver_user",
+            groups="document_page_approval.group_document_approver_user,document_knowledge.group_document_user",
+            name="Test Approver",
+            email="approver@example.com",
+        )
+
+        # Create category and page
+        cls.category1 = cls.category_model.create(
+            {
+                "name": "Demo Category 1",
+                "type": "category",
+            }
+        )
+        cls.page1 = cls.page_obj.create(
+            {
+                "name": "Demo Page 1",
+                "parent_id": cls.category1.id,
+                "content": "<p>Content</p>",
+                "type": "content",
+            }
         )
 
         # Ensure user2 has the approver group
         cls.approver_gid = cls.env.ref(
             "document_page_approval.group_document_approver_user"
         )
-        cls.user2.write({"groups_id": [Command.link(cls.approver_gid.id)]})
 
         # Create category and page that require approval
         cls.category2 = cls.page_obj.create(
@@ -159,7 +179,7 @@ def test_can_user_approve_this_page(self):
         )
 
         # Remove approval group from user2
-        self.user2.write({"groups_id": [(3, self.approver_gid.id)]})
+        self.user2.write({"group_ids": [(3, self.approver_gid.id)]})
         self.assertFalse(
             self.page2.with_user(self.user2).can_user_approve_this_page(self.user2)
         )
@@ -228,8 +248,12 @@ def test_approval_permission_check(self):
             }
         )
 
+        # Use a random user instead of base.user_demo
+        random_user = new_test_user(
+            self.env, login="random_user", groups="base.group_user"
+        )
         with self.assertRaises(UserError):
-            chreq.with_user(self.env.ref("base.user_demo")).action_approve()
+            chreq.with_user(random_user).action_approve()
 
         # Grant approval rights
         chreq.with_user(self.user2).action_approve()

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@`
`3`	`3`
`4`	`4`	`{`
`5`	`5`	`"name": "Document Page Approval",`
`6`		`- "version": "18.0.1.1.0",`
	`6`	`+ "version": "19.0.1.0.0",`
`7`	`7`	`"author": "Savoir-faire Linux, Odoo Community Association (OCA)",`
`8`	`8`	`"website": "https://github.com/OCA/knowledge",`
`9`	`9`	`"license": "AGPL-3",`