[18.0][MIG] stock_account_operating_unit#857
Conversation
OCA-git-bot
added
series:18.0
mod:stock_account_operating_unit
ManfredNelvin-Dev
force-pushed
the
18.0-mig-stock_account_operating_unit
branch
from
ce156fb to
9d0a40d
Compare
AaronHForgeFlow
left a comment
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
can you put the pre-commit changes in a separate commit and then the commit for the migration? thanks.
ManfredNelvin-Dev
force-pushed
the
18.0-mig-stock_account_operating_unit
branch
from
9d0a40d to
d12bdbf
Compare
AaronHForgeFlow
left a comment
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Code review LGTM
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Please squash the commits as explained here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
Added Test Cases. Improved code for test cases Migrated Valuation method of quants. Migrated Valuation method _account_entry_move of quants. Completed test cases and modified valuation method
ManfredNelvin-Dev
force-pushed
the
18.0-mig-stock_account_operating_unit
branch
from
d12bdbf to
3d12359
Compare
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
@ManfredNelvin-Dev the commit history looks incorrect. You squashed commits that should not have been squashed.
You only need to squash bot commits, and commits for the same language and the same author, as explained here: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate
5 participants
Migration of stock_account_operating_unit from Odoo 15.0 to 18.0.