[FIX] api_log: Log readonly exception

Author: SirPyTech

api_log/models/api_log.py

@@ -173,10 +173,10 @@ def log_response(self, response):
         return self.sudo().write(log_response_values)
 
     def _prepare_log_exception(self, exception):
-        exception.headers = getattr(exception, "headers", {})
+        exception_headers = getattr(exception, "headers", {})
         values = {
             "stack_trace": "".join(format_exception(exception)),
-            "response_headers": self._inject_log_entry(exception.headers),
+            "response_headers": self._inject_log_entry(exception_headers),
             "response_body": str(exception),
             "response_date": fields.Datetime.now(),
             "response_time": self._current_time(),

api_log/tests/common.py

@@ -1,11 +1,23 @@
 # Copyright 2025 Simone Rubino - PyTech
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).
 
+import contextlib
+
+from odoo.http import Response
 from odoo.tests.common import HttpCase
 
+from odoo.addons.website.tools import MockRequest
+
 
 class Common(HttpCase):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
         cls.log_model = cls.env["api.log"]
+
+    @contextlib.contextmanager
+    def _mock_request_exc_handling(self, *args, **kwargs):
+        """Enhance the standard mock of a request with exception handling."""
+        with MockRequest(*args, **kwargs) as mock_request:
+            mock_request.dispatcher.handle_error = lambda exc: Response()
+            yield mock_request

api_log/tests/test_api_log.py

@@ -50,6 +50,37 @@ def test_log_response(self):
 
     def test_log_exception(self):
         log = self.log_model.create({})
-        log.log_exception(Exception())
+
+        with self._mock_request_exc_handling(self.env):
+            log.log_exception(Exception())
 
         self.assertEqual(log.response_headers["API-Log-Entry-ID"], str(log.id))
+
+    def test_log_exception_readonly_headers(self):
+        """
+        If the exception's headers are readonly,
+        they can be logged.
+        """
+        # Arrange
+        log = self.log_model.create({})
+        exc_headers = {
+            "answer": 42,
+        }
+
+        class ReadOnlyException(Exception):
+            @property
+            def headers(self):
+                return exc_headers.copy()
+
+        ro_exception = ReadOnlyException()
+        # pre-condition
+        with self.assertRaises(AttributeError) as ae:
+            ro_exception.headers = dict()
+        self.assertIn("can't set attribute", str(ae.exception))
+
+        # Act
+        with self._mock_request_exc_handling(self.env):
+            log.log_exception(ro_exception)
+
+        # Assert
+        self.assertLess(exc_headers.items(), log.response_headers.items())