[MIG] auth_partner: Migration to 18.0

Author: paradoxxxzero

auth_partner/__manifest__.py

@@ -6,7 +6,7 @@
 {
     "name": "Partner Auth",
     "summary": "Implements the base features for a authenticable partner",
-    "version": "16.0.1.0.0",
+    "version": "18.0.1.0.0",
     "license": "AGPL-3",
     "author": "Akretion,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/rest-framework",
@@ -19,7 +19,6 @@
     "data": [
         "security/res_group.xml",
         "security/ir.model.access.csv",
-        "security/ir_rule.xml",
         "data/email_data.xml",
         "wizards/wizard_auth_partner_force_set_password_view.xml",
         "wizards/wizard_auth_partner_reset_password_view.xml",

auth_partner/data/email_data.xml

@@ -7,7 +7,7 @@
         <field name="partner_to">{{object.partner_id.id}}</field>
         <field name="model_id" ref="model_auth_partner" />
         <field name="auto_delete" eval="True" />
-        <field name="lang">${object.partner_id.lang}</field>
+        <field name="lang">{{object.partner_id.lang}}</field>
         <field name="body_html" type="html">
             <div>
             Hi <t t-out="object.partner_id.name or ''" />

auth_partner/i18n/auth_partner.pot

@@ -397,7 +397,7 @@ msgstr ""
 #. odoo-python
 #: code:addons/auth_partner/wizards/wizard_auth_partner_force_set_password.py:0
 #, python-format
-msgid "No active_id in context"
+msgid "No id in context"
 msgstr ""
 
 #. module: auth_partner

auth_partner/i18n/it.po

@@ -435,8 +435,8 @@ msgstr "N° reset inviati in attesa"
 #. odoo-python
 #: code:addons/auth_partner/wizards/wizard_auth_partner_force_set_password.py:0
 #, python-format
-msgid "No active_id in context"
-msgstr "Manca active_id nel context"
+msgid "No id in context"
+msgstr "Manca id nel context"
 
 #. module: auth_partner
 #. odoo-python

auth_partner/models/auth_directory.py

@@ -8,7 +8,7 @@
 
 import jwt
 
-from odoo import _, fields, models
+from odoo import fields, models
 from odoo.exceptions import UserError
 
 from odoo.addons.queue_job.delay import chain
@@ -86,18 +86,17 @@ def action_regenerate_secret_key(self):
         self.secret_key = self._generate_default_secret_key()
 
     def _compute_count_partner(self):
-        data = self.env["auth.partner"].read_group(
+        data = self.env["auth.partner"]._read_group(
             [
                 ("directory_id", "in", self.ids),
             ],
             ["directory_id"],
-            groupby=["directory_id"],
-            lazy=False,
+            aggregates=["__count"],
         )
-        res = {item["directory_id"][0]: item["__count"] for item in data}
+        mapped_data = {auth_partner.id: count for auth_partner, count in data}
 
         for record in self:
-            record.count_partner = res.get(record.id, 0)
+            record.count_partner = mapped_data.get(record.id, 0)
 
     def _get_template(self, type_or_template):
         if isinstance(type_or_template, str):
@@ -127,7 +126,8 @@ def _send_mail_background(
         return job.delay()
 
     def _send_mail(self, type_or_template, auth_partner, **context):
-        """Send an email to the auth_partner using the template defined in the directory"""
+        """Send an email to the auth_partner using the template defined
+        in the directory"""
         self.ensure_one()
         auth_partner.ensure_one()
         context = self._prepare_mail_context(context)
@@ -138,7 +138,9 @@ def _send_mail_impl(self, type_or_template, auth_partner, **context):
         template = self.sudo()._get_template(type_or_template)
         if not template:
             raise UserError(
-                _("No email template defined for %(template)s in %(directory)s")
+                self.env._(
+                    "No email template defined for %(template)s in %(directory)s"
+                )
                 % {"template": type_or_template, "directory": self.name}
             )
         template.sudo().with_context(**context).send_mail(
@@ -176,10 +178,10 @@ def _decode_token(
                     token, algorithms=["HS256"], options={"verify_signature": False}
                 )
             except jwt.PyJWTError as e:
-                raise UserError(_("Invalid Token")) from e
+                raise UserError(self.env._("Invalid Token")) from e
             probable_auth_partner = self.env["auth.partner"].browse(obj["ap"])
             if not probable_auth_partner:
-                raise UserError(_("Invalid Token"))
+                raise UserError(self.env._("Invalid Token"))
             key += key_salt(probable_auth_partner)
 
         try:
@@ -191,7 +193,7 @@ def _decode_token(
                 algorithms=["HS256"],
             )
         except jwt.PyJWTError as e:
-            raise UserError(_("Invalid Token")) from e
+            raise UserError(self.env._("Invalid Token")) from e
 
         auth_partner = self.env["auth.partner"].browse(obj["ap"])
 
@@ -200,7 +202,7 @@ def _decode_token(
             or not auth_partner
             or auth_partner.directory_id != self
         ):
-            raise UserError(_("Invalid token"))
+            raise UserError(self.env._("Invalid token"))
 
         return auth_partner
 

auth_partner/models/auth_partner.py

@@ -8,7 +8,7 @@
 
 import passlib
 
-from odoo import _, api, fields, models
+from odoo import api, fields, models
 from odoo.exceptions import AccessDenied
 
 # please read passlib great documentation
@@ -67,7 +67,8 @@ class AuthPartner(models.Model):
     )
 
     mail_verified = fields.Boolean(
-        help="This field is set to True when the user has clicked on the link sent by email"
+        help="This field is set to True when the user has clicked on the link "
+        "sent by email"
     )
 
     _sql_constraints = [
@@ -96,7 +97,7 @@ def _check_no_empty(self, login, password):
             raise AccessDenied()
 
     def _get_hashed_password(self, directory, login):
-        self.flush()
+        self.flush_model()
         self.env.cr.execute(
             """
             SELECT id, COALESCE(encrypted_password, '')
@@ -170,11 +171,11 @@ def _login(self, directory, login, password, **kwargs):
             auth_partner = None
 
         if not auth_partner or not auth_partner.partner_id.active:
-            raise AccessDenied(_("Invalid Login or Password"))
+            raise AccessDenied(self.env._("Invalid Login or Password"))
 
         if directory.sudo().force_verified_email and not auth_partner.mail_verified:
             raise AccessDenied(
-                _(
+                self.env._(
                     "Email address not validated. Validate your email address by "
                     "clicking on the link in the email sent to you or request a new "
                     "password. "
@@ -210,7 +211,9 @@ def _get_impersonate_action(self, token, **kwargs):
     def impersonate(self):
         self.ensure_one()
         if self.env.user not in self.impersonating_user_ids:
-            raise AccessDenied(_("You are not allowed to impersonate this user"))
+            raise AccessDenied(
+                self.env._("You are not allowed to impersonate this user")
+            )
 
         token = self._generate_impersonating_token()
         return self._get_impersonate_action(token)

auth_partner/models/res_partner.py

@@ -15,18 +15,17 @@ class ResPartner(models.Model):
     )
 
     def _compute_auth_partner_count(self):
-        data = self.env["auth.partner"].read_group(
+        data = self.env["auth.partner"]._read_group(
             [
                 ("partner_id", "in", self.ids),
             ],
             ["partner_id"],
-            groupby=["partner_id"],
-            lazy=False,
+            aggregates=["__count"],
         )
-        res = {item["partner_id"][0]: item["__count"] for item in data}
+        mapped_data = {auth_partner.id: count for auth_partner, count in data}
 
         for record in self:
-            record.auth_partner_count = res.get(record.id, 0)
+            record.auth_partner_count = mapped_data.get(record.id, 0)
 
     def _get_auth_partner_for_directory(self, directory):
         return self.sudo().auth_partner_ids.filtered(

auth_partner/security/ir_rule.xml

@@ -14,7 +14,13 @@ class CommonTestAuthPartner(TransactionCase, MockEmail):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.env = cls.env(context=dict(cls.env.context, queue_job__no_delay=True))
+        cls.env = cls.env(
+            context=dict(
+                cls.env.context,
+                queue_job__no_delay=True,
+                tracking_disable=True,
+            )
+        )
 
         cls.partner = cls.env.ref("auth_partner.res_partner_auth_demo")
         cls.other_partner = cls.partner.copy(
@@ -42,14 +48,15 @@ def new_mails(self):
         class MailsProxy(mailmail.__class__):
             __slots__ = ["_prev", "__weakref__"]
 
-            def __init__(self):
+            def __init__(self, env, ids, prefetch_ids):
+                super().__init__(env, ids, prefetch_ids)
                 object.__setattr__(self, "_prev", mailmail.search([]))
 
             def __getattribute__(self, name: str) -> Any:
                 mails = mailmail.search([]) - object.__getattribute__(self, "_prev")
                 return object.__getattribute__(mails, name)
 
-        new_mails = MailsProxy()
+        new_mails = MailsProxy(self.env, [], [])
         with self.mock_mail_gateway():
             yield new_mails
 

auth_partner/tests/common.py

@@ -3,9 +3,9 @@
     <record id="auth_directory_view_tree" model="ir.ui.view">
         <field name="model">auth.directory</field>
         <field name="arch" type="xml">
-            <tree>
+            <list>
                 <field name="name" />
-            </tree>
+            </list>
         </field>
     </record>
 
@@ -28,10 +28,14 @@
                             name="%(auth_partner_action)d"
                             icon="fa-user"
                             type="action"
-                            context="{'default_directory_id': active_id, 'search_default_directory_id': active_id}"
+                            context="{'default_directory_id': id, 'search_default_directory_id': id}"
                         >
-                            <field name="count_partner" />
-                            Account
+                            <div class="o_field_widget o_stat_info">
+                                <span class="o_stat_value">
+                                    <field name="count_partner" />
+                                </span>
+                                <span class="o_stat_text">Accounts</span>
+                            </div>
                         </button>
                     </div>
                     <div class="oe_title">
@@ -77,7 +81,7 @@
         <field name="name">Directory</field>
         <field name="type">ir.actions.act_window</field>
         <field name="res_model">auth.directory</field>
-        <field name="view_mode">tree,form</field>
+        <field name="view_mode">list,form</field>
         <field name="search_view_id" ref="auth_directory_view_search" />
         <field name="domain">[]</field>
         <field name="context">{}</field>