[18.0][MIG] rest_log#509
Merged
Merged
Conversation
glitchov
force-pushed
the
18.0-mig-rest_log-hda
branch
9 times, most recently
from
9b70b9e to
5605139
Compare
Contributor
|
/ocabot migration rest_log |
Contributor
|
@glitchov Thank you for the migration. Can you fix the test plz? |
Contributor
Extrapolate feature from OCA/wms/shopfloor.
Previous hook was cloning the table but by doing so SQL sequences and indexes were missing.
This commit odoo/odoo@9a129ca refactored MockRequest which breaks tests.
Some endpoints will not return a dict as expected by the ``_dispatch_with_db_logging`` method (and the other methods called within), but an object of type ``odoo.http.Response``. When that happens, the instance fails to handle it while creating logs (ie: tries to call ``json.dumps()`` on such object, which is not allowed). This patch should fix the issue.
This way we can hook an manipulate data w/out having to decode from JSON back and forth.
Currently translated at 100.0% (41 of 41 strings) Translation: rest-framework-16.0/rest-framework-16.0-rest_log Translate-URL: https://translation.odoo-community.org/projects/rest-framework-16-0/rest-framework-16-0-rest_log/it/
Currently translated at 100.0% (41 of 41 strings) Translation: rest-framework-16.0/rest-framework-16.0-rest_log Translate-URL: https://translation.odoo-community.org/projects/rest-framework-16-0/rest-framework-16-0-rest_log/it/
lmignon
force-pushed
the
18.0-mig-rest_log-hda
branch
from
5605139 to
0a2874f
Compare
In case of a retryable error, the initial error must bubble up to the retrying mechanism. If this kind of error is wrapped into another one, the retrying mechanism no more works
lmignon
force-pushed
the
18.0-mig-rest_log-hda
branch
from
0a2874f to
9cd7d4d
Compare
Contributor
|
/ocabot merge nobump |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at d946bf1. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration from 16.0