Skip to content

[17.0][MIG] fastapi_auth_api_key#555

Merged
OCA-git-bot merged 5 commits into
OCA:17.0from
petrus-v:17.0-mig-fastapi_auth_api_key
Oct 21, 2025
Merged

[17.0][MIG] fastapi_auth_api_key#555
OCA-git-bot merged 5 commits into
OCA:17.0from
petrus-v:17.0-mig-fastapi_auth_api_key

Conversation

@petrus-v

@petrus-v petrus-v commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

@petrus-v petrus-v changed the base branch from 14.0 to 17.0 August 7, 2025 11:16
@petrus-v petrus-v force-pushed the 17.0-mig-fastapi_auth_api_key branch from c459d2a to 8e0d443 Compare August 7, 2025 11:18
@petrus-v petrus-v mentioned this pull request Aug 7, 2025
Closed
Tisho99
Tisho99 reviewed Aug 8, 2025
View reviewed changes

@Tisho99 Tisho99 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, some minor comments.

The PR looks good to me.

I have closed a similar PR to focus community efforts on this one.

Comment thread fastapi_auth_api_key/dependencies.py Outdated
Comment thread fastapi_auth_api_key/tests/test_fastapi_api_key_dependencies.py Outdated
@sebastienbeau sebastienbeau added this to the 17.0 milestone Sep 1, 2025
@petrus-v petrus-v force-pushed the 17.0-mig-fastapi_auth_api_key branch from 8e0d443 to d90f40e Compare September 8, 2025 09:04
@petrus-v petrus-v mentioned this pull request Sep 8, 2025
Closed
@petrus-v petrus-v force-pushed the 17.0-mig-fastapi_auth_api_key branch from d90f40e to 0d7e53c Compare September 8, 2025 09:25
Tisho99
Tisho99 approved these changes Sep 8, 2025
View reviewed changes

@Tisho99 Tisho99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petrus-v petrus-v force-pushed the 17.0-mig-fastapi_auth_api_key branch 2 times, most recently from 593e388 to 697ff1c Compare September 8, 2025 12:48
@petrus-v petrus-v force-pushed the 17.0-mig-fastapi_auth_api_key branch from 697ff1c to 4e547bc Compare September 8, 2025 13:10
@OCA-git-bot

OCA-git-bot commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivantodorovich
ivantodorovich approved these changes Sep 24, 2025
View reviewed changes
Comment thread fastapi_auth_api_key/dependencies.py
from fastapi.exceptions import HTTPException
from fastapi.security import APIKeyHeader

HTTP_API_KEY_HEADER = os.environ.get("FASTAPI_AUTH_HTTP_API_KEY_HEADER", "HTTP-API-KEY")

@ivantodorovich ivantodorovich Sep 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: I think we should make this configurable in the fastapi.endpoint.
Makes it easier to setup in environments without control of the env variables, like in Odoo.sh

@ivantodorovich

ivantodorovich commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

@OCA/rest-framework-maintainers can we merge this one? 🙏🏻

@yankinmax yankinmax mentioned this pull request Oct 2, 2025
Merged
1 task
@thomaspaulb

thomaspaulb commented Oct 21, 2025

Copy link
Copy Markdown

/ocabot migration fastapi_auth_api_key

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-555-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Oct 21, 2025
Open
19 tasks
@OCA-git-bot OCA-git-bot merged commit a45e720 into OCA:17.0 Oct 21, 2025
7 checks passed
@OCA-git-bot

OCA-git-bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 49ae83f. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot

OCA-git-bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

It looks like something changed on 17.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 17.0-ocabot-merge-pr-555-by-thomaspaulb-bump-nobump, awaiting test results.

@OCA-git-bot

OCA-git-bot commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 7ef6350. Thanks a lot for contributing to OCA. ❤️

@florentx florentx mentioned this pull request Jul 2, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@ivantodorovich ivantodorovich ivantodorovich approved these changes
@henrybackman henrybackman henrybackman approved these changes
@Tisho99 Tisho99 Tisho99 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

8 participants

@petrus-v @OCA-git-bot @ivantodorovich @thomaspaulb @henrybackman @Tisho99 @sebastienbeau @mmequignon