Skip to content

[FIX] base_rest_auth_api_key: fix method security plugin#557

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
emadshaaban92:patch-2
Feb 10, 2026
Merged

[FIX] base_rest_auth_api_key: fix method security plugin#557
OCA-git-bot merged 1 commit into
OCA:18.0from
emadshaaban92:patch-2

Conversation

@emadshaaban92

@emadshaaban92 emadshaaban92 commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@OCA-git-bot

OCA-git-bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@sebastienbeau sebastienbeau added this to the 18.0 milestone Sep 1, 2025
@github-actions

github-actions Bot commented Jan 4, 2026

Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 4, 2026
@github-actions github-actions Bot closed this Feb 8, 2026
@simahawk simahawk reopened this Feb 9, 2026
@OCA-git-bot

OCA-git-bot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

simahawk
simahawk reviewed Feb 9, 2026
View reviewed changes

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your fix proposal!

Comment thread base_rest_auth_api_key/apispec/rest_method_security_plugin.py Outdated

def operation_helper(self, path=None, operations=None, **kwargs):
routing = kwargs.get("routing")
routing = kwargs.get("original_routing")

@simahawk simahawk Feb 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably use https://github.com/OCA/rest-framework/blob/18.0/base_rest/tools.py#L10

@emadshaaban92 emadshaaban92 Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review, I rebased and made the change

simahawk
simahawk approved these changes Feb 10, 2026
View reviewed changes

@simahawk simahawk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simahawk simahawk removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 10, 2026
@lmignon

lmignon commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

/ocabot merge patch

@OCA-git-bot

OCA-git-bot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-557-by-lmignon-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6420eaf into OCA:18.0 Feb 10, 2026
6 of 7 checks passed
@OCA-git-bot

OCA-git-bot commented Feb 10, 2026

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 54b2678. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simahawk simahawk simahawk approved these changes
@lmignon lmignon lmignon approved these changes

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

5 participants

@emadshaaban92 @OCA-git-bot @lmignon @simahawk @sebastienbeau