[IMP] connector_elasticsearch: timeout and retries#208
Merged
Conversation
gurneyalex
force-pushed
the
retry-connection-read-timeout
branch
2 times, most recently
from
06c3f8d to
6fb0bcd
Compare
Add configuration options on the elasticsearch backend model to support passing the timeout / max_retries / retry_on_timeout argument to the Elasticsearch constructor.
gurneyalex
force-pushed
the
retry-connection-read-timeout
branch
from
6fb0bcd to
609faa4
Compare
santostelmo
approved these changes
May 27, 2025
simahawk
approved these changes
May 28, 2025
Contributor
|
/ocabot merge minor |
Contributor
|
This PR looks fantastic, let's merge it! |
rvalyi
requested changes
May 28, 2025
| es_max_retries = fields.Integer( | ||
| string="Elasticsearch max retries", | ||
| default=0, | ||
| help="Number of retries, when an occurs. " |
Contributor
|
Congratulations, your PR was merged at e227abc. Thanks a lot for contributing to OCA. ❤️ |
gurneyalex
added a commit
to camptocamp/search-engine
that referenced
this pull request
Jun 16, 2025
PR OCA#208 introduced configurable timeouts and retries on the ES backend. However the implementation only added this feature for auth_type api_key and not for HTTP simple auth. This pull request adds the missing support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration options on the elasticsearch backend model to support passing the timeout / max_retries / retry_on_timeout argument to the Elasticsearch constructor.