Skip to content

[16.0] Connector typesense#210

Merged
OCA-git-bot merged 3 commits into
OCA:16.0from
akretion:connector_typesense
Sep 1, 2025
Merged

[16.0] Connector typesense#210
OCA-git-bot merged 3 commits into
OCA:16.0from
akretion:connector_typesense

Conversation

@sebastienbeau
Copy link
Copy Markdown
Member

@sebastienbeau sebastienbeau commented Jun 4, 2025 •
edited
Loading

This PR is a refactor of this previous PR

Depends on

@MrTango @kobros-tech the change are ok for you ?

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 4, 2025

Hi @lmignon,
some modules you are maintaining are being modified, check this out!

@sebastienbeau sebastienbeau force-pushed the connector_typesense branch from eaaad6b to 80d7d08 Compare June 4, 2025 15:50
sebastienbeau
sebastienbeau commented Jun 4, 2025
View reviewed changes
Comment thread connector_typesense/__manifest__.py Outdated
Comment thread connector_typesense/tools/adapter.py Outdated
@sebastienbeau sebastienbeau marked this pull request as draft June 4, 2025 15:56
@sebastienbeau sebastienbeau mentioned this pull request Jun 4, 2025
Closed
@sebastienbeau sebastienbeau force-pushed the connector_typesense branch from 80d7d08 to 72f30f0 Compare June 4, 2025 16:05
@kobros-tech
Copy link
Copy Markdown
Contributor

kobros-tech commented Jun 5, 2025

ok

@kobros-tech
Copy link
Copy Markdown
Contributor

kobros-tech commented Jun 5, 2025

I think we can delete all cassette files and update the test cases with new cassette file based on the changes you made?

@sebastienbeau sebastienbeau force-pushed the connector_typesense branch from 72f30f0 to 8bc645f Compare June 6, 2025 18:05
@sebastienbeau sebastienbeau marked this pull request as ready for review June 6, 2025 18:12
@sebastienbeau sebastienbeau mentioned this pull request Jun 6, 2025
Closed
3 tasks
@sebastienbeau sebastienbeau changed the title Connector typesense work in progress [16.0] Connector typesense Jun 6, 2025
@sebastienbeau
Copy link
Copy Markdown
Member Author

sebastienbeau commented Jun 6, 2025

It's ready.
After merging it, I will create the branch 18.0 and migration the modules !

MrTango
MrTango approved these changes Jun 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrTango MrTango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jun 25, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kobros-tech
Copy link
Copy Markdown
Contributor

kobros-tech commented Jul 4, 2025

@sebastienbeau

Are we ready to go ahead?

@HviorForgeFlow
Copy link
Copy Markdown
Member

HviorForgeFlow commented Aug 19, 2025

could you squash fixup commits? thanks!

@kobros-tech
Copy link
Copy Markdown
Contributor

kobros-tech commented Aug 19, 2025

ping @sebastienbeau

@sebastienbeau sebastienbeau added this to the 16.0 milestone Aug 31, 2025
@sebastienbeau
Copy link
Copy Markdown
Member Author

sebastienbeau commented Sep 1, 2025

This PR have been merged : #211
I am going to rebase and quash and merge this PR

MrTango and others added 3 commits September 1, 2025 10:32
@MrTango @sebastienbeau
[ADD] connector_typesense
fbe4fec
@kobros-tech @sebastienbeau
connector_typesense: Add test, improve code, clean readme
5075edc
@sebastienbeau
connector_typesense: refactor code
5220279 
Implement a simple update of setting (I recommend to use typesense-dashbord for advanced config)
Disable reindex and remove alias logic as it's complex and not needed, schema can be updated
Reuse generic and add some specific typesense test
@sebastienbeau
Copy link
Copy Markdown
Member Author

sebastienbeau commented Sep 1, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Sep 1, 2025

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-210-by-sebastienbeau-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c9b1214 into OCA:16.0 Sep 1, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Sep 1, 2025

Congratulations, your PR was merged at 9d7ac88. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@MrTango MrTango MrTango approved these changes

@kobros-tech kobros-tech kobros-tech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sebastienbeau @OCA-git-bot @kobros-tech @HviorForgeFlow @MrTango