[16.0] fix se mark to update#212
Merged
Merged
Conversation
qgroulard
approved these changes
Jun 10, 2025
Contributor
qgroulard
left a comment
qgroulard
left a comment
There was a problem hiding this comment.
LGTM (code review).
Probably my proposition was a bit overkill, this simple fix makes the job.
sebastienbeau
force-pushed
the
16.0-fix-se_mark_to_update
branch
from
07e571c to
09f4875
Compare
Member
Author
|
I rebase it, should be ready for merge |
Member
Author
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 4c1444d. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue : OCA/sale-channel#15
Mark update should not change the state of binding that are planned to be deleted
Check the last commit : @qgroulard
Depends on (include commit):