Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion connector_search_engine/models/se_indexable_record.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ def _remove_from_index(self, indexes: SeIndex) -> None:
def _se_mark_to_update(self, indexes: SeIndex | None = None) -> None:
"""Mark the record to be updated in the index."""
bindings = self._get_bindings(indexes)
bindings.write({"state": "to_recompute"})
bindings.filtered(lambda s: s.state != "to_delete").write(
{"state": "to_recompute"}
)

def unlink(self):
bindings = self.sudo()._get_bindings()
Expand Down
19 changes: 19 additions & 0 deletions connector_search_engine/tests/test_all.py
Original file line number Diff line number Diff line change
Expand Up @@ -370,3 +370,22 @@ def test_resynchronize_all_bindings(self):
self.assertEqual(len(calls), 2)
self.assertEqual(calls[1]["method"], "delete")
self.assertEqual(calls[1]["args"], [none_existing_partner_id, "wtf"])

def test_se_mark_to_update(self):
self.partners = self.env["res.partner"].create(
[
{"name": "Foo"},
{"name": "Bar"},
]
)
self.partners._add_to_index(self.se_index)

# Now for some reason the first partner is removed from the index
self.partners[0]._remove_from_index(self.se_index)

# And something (like a write) trigger an "_se_mark_to_update"
self.partners._se_mark_to_update()

# We ensure that the binding is still in "to_delete"
self.assertEqual(self.partners[0].se_binding_ids.state, "to_delete")
self.assertEqual(self.partners[1].se_binding_ids.state, "to_recompute")