[IMP] vault: Don't require keys on service load to avoid annoying notifications

Author: CarlosRoca13

vault/static/src/backend/controller.esm.js

@@ -71,37 +71,42 @@ patch(FormController.prototype, {
      * @private
      */
     async _newVaultKeyPair() {
-        // Get the current private key
-        const private_key = await this.vault.get_private_key();
-
-        // Generate new keys
-        await this.vault.generate_keys();
-
-        const public_key = await this.vault.get_public_key();
+        this.uuid = await this.vault._check_database();
+        if (this.uuid) {
+            // The user has a private key so get it
+            const private_key = await this.vault.get_private_key();
+
+            // Generate new keys
+            await this.vault.generate_keys();
+
+            const public_key = await this.vault.get_public_key();
+
+            // Re-encrypt the master keys
+            const master_keys = await rpc("/vault/rights/get");
+            let result = {};
+            for (const uuid in master_keys) {
+                result[uuid] = await this.vault_utils.wrap(
+                    await this.vault_utils.unwrap(master_keys[uuid], private_key),
+                    public_key
+                );
+            }
 
-        // Re-encrypt the master keys
-        const master_keys = await rpc("/vault/rights/get");
-        let result = {};
-        for (const uuid in master_keys) {
-            result[uuid] = await this.vault_utils.wrap(
-                await this.vault_utils.unwrap(master_keys[uuid], private_key),
-                public_key
-            );
-        }
+            await rpc("/vault/rights/store", {keys: result});
 
-        await rpc("/vault/rights/store", {keys: result});
+            // Re-encrypt the inboxes to not loose it
+            const inbox_keys = await rpc("/vault/inbox/get");
+            result = {};
+            for (const uuid in inbox_keys) {
+                result[uuid] = await this.vault_utils.wrap(
+                    await this.vault_utils.unwrap(inbox_keys[uuid], private_key),
+                    public_key
+                );
+            }
 
-        // Re-encrypt the inboxes to not loose it
-        const inbox_keys = await rpc("/vault/inbox/get");
-        result = {};
-        for (const uuid in inbox_keys) {
-            result[uuid] = await this.vault_utils.wrap(
-                await this.vault_utils.unwrap(inbox_keys[uuid], private_key),
-                public_key
-            );
+            await rpc("/vault/inbox/store", {keys: result});
+        } else {
+            await this.vault._initialize_keys();
         }
-
-        await rpc("/vault/inbox/store", {keys: result});
     },
 
     /**

vault/static/src/backend/vault.esm.js

@@ -44,24 +44,6 @@ const vaultService = {
         }
 
         class Vault {
-            /**
-             * Check if the user actually has keys otherwise generate them on init
-             *
-             * @override
-             */
-            constructor() {
-                const self = this;
-
-                function waitAndCheck() {
-                    if (!vault_utils.supported()) return null;
-
-                    if (odoo.isReady) self._initialize_keys();
-                    else setTimeout(waitAndCheck, 500);
-                }
-
-                setTimeout(waitAndCheck, 500);
-            }
-
             /**
              * Generate a new key pair and export to database and object store
              */