[IMP] cross_connect_client: Require and send mail

Author: paradoxxxzero

cross_connect_client/models/cross_connect_server.py

@@ -113,10 +113,14 @@ def _get_cross_connect_url(self, redirect_url=None):
         if not groups:
             raise UserError(_("You are not allowed to access this server"))
 
+        if not self.env.user.email:
+            raise UserError(_("User email is required"))
+
         data = {
             "id": self.env.user.id,
             "name": self.env.user.name,
             "login": self.env.user.login,
+            "email": self.env.user.email,
             "lang": self.env.user.lang,
             "groups": [group.cross_connect_server_group_id for group in groups],
         }

cross_connect_client/tests/test_cross_connect_client.py

@@ -121,7 +121,7 @@ def test_sync(self, req):
         self.assertEqual(
             self.server.menu_id.action.url, f"/cross_connect_server/{self.server.id}"
         )
-        self.assertEqual(self.server.menu_id.action.target, "self")
+        self.assertEqual(self.server.menu_id.action.target, "new")
 
         self.assertTrue(self.server.web_icon_data)
 
@@ -178,7 +178,13 @@ def test_get_cross_connect_url(self, req):
         )
         self.server.action_sync()
 
-        user = self.env["res.users"].create({"name": "Test User", "login": "test_user"})
+        user = self.env["res.users"].create(
+            {
+                "name": "Test User",
+                "login": "test_user",
+                "email": "test@example.com",
+            }
+        )
         group = self.server.group_ids[0]
         user.write({"groups_id": [(4, group.id)]})
 
@@ -198,6 +204,7 @@ def test_get_cross_connect_url(self, req):
                 "id": user.id,
                 "name": "Test User",
                 "login": "test_user",
+                "email": "test@example.com",
                 "lang": "en_US",
                 "groups": [group.cross_connect_server_group_id],
             },
@@ -220,7 +227,13 @@ def test_get_cross_connect_url_bad_groups(self, req):
         )
         self.server.action_sync()
 
-        user = self.env["res.users"].create({"name": "Test User", "login": "test_user"})
+        user = self.env["res.users"].create(
+            {
+                "name": "Test User",
+                "login": "test_user",
+                "email": "test@example.com",
+            }
+        )
 
         req.reset_mock()
         req.return_value = _mock_json({"client_id": 1, "token": "test-token"})
@@ -254,7 +267,12 @@ def test_act_url_redirect(self):
             server.action_sync()
 
         user = self.env["res.users"].create(
-            {"name": "Test User", "login": "test_user", "password": "user_pas$w0rd"}
+            {
+                "name": "Test User",
+                "login": "test_user",
+                "email": "test@example.com",
+                "password": "user_pas$w0rd",
+            }
         )
         group = server.group_ids[0]
         user.write({"groups_id": [(4, group.id)]})