[FIX] auth_saml: avoid redirecting when there is a SAML error

vincent-hatakeyama · vincent-hatakeyama · commit cfd88e595714 · 2025-02-11T17:27:50.000+01:00
diff --git a/auth_saml/controllers/main.py b/auth_saml/controllers/main.py
@@ -83,7 +83,7 @@ def _saml_autoredirect(self):
         autoredirect_providers = self.list_saml_providers(True)
         # do not redirect if asked too or if a SAML error has been found
         disable_autoredirect = (
-            "disable_autoredirect" in request.params or "error" in request.params
+            "disable_autoredirect" in request.params or "saml_error" in request.params
         )
         if autoredirect_providers and not disable_autoredirect:
             return werkzeug.utils.redirect(
diff --git a/auth_saml/readme/newsfragments/+avoid_autoredirect_loop.bugfix b/auth_saml/readme/newsfragments/+avoid_autoredirect_loop.bugfix
@@ -0,0 +1 @@
+Avoid redirecting when there is a SAML error.

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ def _saml_autoredirect(self):`
`83`	`83`	`autoredirect_providers = self.list_saml_providers(True)`
`84`	`84`	`# do not redirect if asked too or if a SAML error has been found`
`85`	`85`	`disable_autoredirect = (`
`86`		`- "disable_autoredirect" in request.params or "error" in request.params`
	`86`	`+ "disable_autoredirect" in request.params or "saml_error" in request.params`
`87`	`87`	`)`
`88`	`88`	`if autoredirect_providers and not disable_autoredirect:`
`89`	`89`	`return werkzeug.utils.redirect(`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Avoid redirecting when there is a SAML error.`