[18.0][MIG] auth_oauth_multi_token: Migration to 18.0#743
[18.0][MIG] auth_oauth_multi_token: Migration to 18.0#743kobros-tech wants to merge 20 commits intoOCA:18.0from
Conversation
Allow multiple oauth login at the same time.
* cleanup, improve, docstrings * add tests
Nothing special. Just making linters happy and splitting the readme. @Tecnativa TT25619
Otherwise lookup is slow when there are many users.
Otherwise you can't delete a user.
This is cosmetic only, because this field is not used when auth_oauth_multi_token is installed.
Currently translated at 100.0% (15 of 15 strings) Translation: server-auth-16.0/server-auth-16.0-auth_oauth_multi_token Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_oauth_multi_token/it/
dnplkndll
left a comment
dnplkndll
left a comment
There was a problem hiding this comment.
looks good functional test, oidc aws cognito
|
@sbidoul could you review this PR and 17.0 one too? |
| ) | ||
| # In version 18.0 AccessDenied exception is raising ValueError exception | ||
| except ValueError as e: | ||
| self.assertEqual(str(e), "Unknown token version") |
There was a problem hiding this comment.
This change to the test looks suspicious to me. It probably does not test what it was meant to test anymore.
There was a problem hiding this comment.
not at all, in version 17.0
there is one single exception raised, the one you mean!
In version 18.0, the exception you mean is raising another exception which is the source one.
I handle it and then I trace the log message for the one you mean.
If you like to update the test case all right show me your opinion.
There was a problem hiding this comment.
could I suggest:
a8955ff
prevent attempt to create versus refuse. or did we want to change the expects to be a new user?
'Exception: Unknown token version'
is thrown in the https://github.com/odoo/odoo/blob/18.0/addons/auth_oauth/models/res_users.py#L111 I believe.
kobros-tech
force-pushed
the
18.0-mig-auth_oauth_multi_token
branch
from
b14b991 to
8ea5c67
Compare
|
forwarded to #754 |
8 participants
Based on PR 742 which is just improvement of PR 694
#694 => #742 [17.0][MIG]