[17.0][FIX] auth_saml: avoid redirecting when there is a SAML error#761
Merged
OCA-git-bot merged 1 commit intoOCA:17.0from May 13, 2025
Merged
Conversation
StefanRijnhart
approved these changes
Feb 12, 2025
Member
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Thanks! I see it's saml_error in https://github.com/OCA/server-auth/blob/17.0/auth_saml/controllers/main.py#L134 as well.
vincent-hatakeyama
force-pushed
the
bugfix/17.0/auth_saml/avoid_autoredirect_loop
branch
from
cfd88e5 to
3a5cde2
Compare
vincent-hatakeyama
force-pushed
the
bugfix/17.0/auth_saml/avoid_autoredirect_loop
branch
from
3a5cde2 to
07b9402
Compare
Contributor
Author
|
/ocabot merge patch |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 5d1f0c5. Thanks a lot for contributing to OCA. ❤️ |
vincent-hatakeyama
deleted the
bugfix/17.0/auth_saml/avoid_autoredirect_loop
branch
This was referenced May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.