[18.0][MIG] password_security

.copier-answers.yml

@@ -17,7 +17,8 @@ odoo_test_flavor: Both
 odoo_version: 18.0
 org_name: Odoo Community Association (OCA)
 org_slug: OCA
-rebel_module_groups: []
+rebel_module_groups:
+  - password_security
 repo_description: server-auth
 repo_name: server-auth
 repo_slug: server-auth

.github/workflows/test.yml

@@ -36,8 +36,17 @@ jobs:
       matrix:
         include:
           - container: ghcr.io/oca/oca-ci/py3.10-odoo18.0:latest
+            include: "password_security"
             name: test with Odoo
           - container: ghcr.io/oca/oca-ci/py3.10-ocb18.0:latest
+            include: "password_security"
+            name: test with OCB
+            makepot: "true"
+          - container: ghcr.io/oca/oca-ci/py3.10-odoo18.0:latest
+            exclude: "password_security"
+            name: test with Odoo
+          - container: ghcr.io/oca/oca-ci/py3.10-ocb18.0:latest
+            exclude: "password_security"
             name: test with OCB
             makepot: "true"
     services:
@@ -51,6 +60,8 @@ jobs:
           - 5432:5432
     env:
       OCA_ENABLE_CHECKLOG_ODOO: "1"
+      INCLUDE: "${{ matrix.include }}"
+      EXCLUDE: "${{ matrix.exclude }}"
     steps:
       - uses: actions/checkout@v4
         with:

auth_oidc/tests/test_auth_oidc_auth_code.py

@@ -242,15 +242,13 @@ def test_login_without_any_key(self):
             keys=[],
         )
 
-        with (
-            self.assertRaises(AccessDenied),
-            MockRequest(self.env),
-            self.assertLogs(level=logging.ERROR) as logs,
-        ):
-            self.env["res.users"].auth_oauth(
-                self.provider_rec.id,
-                {"state": json.dumps({})},
-            )
+        with self.assertRaises(AccessDenied):
+            with MockRequest(self.env):
+                with self.assertLogs(level=logging.ERROR) as logs:
+                    self.env["res.users"].auth_oauth(
+                        self.provider_rec.id,
+                        {"state": json.dumps({})},
+                    )
         self.assertEqual(len(logs.records), 1)
         self.assertEqual(logs.records[0].levelno, logging.ERROR)
         self.assertEqual(

password_security/README.rst

@@ -0,0 +1,135 @@
+=================
+Password Security
+=================
+
+.. 
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! This file is generated by oca-gen-addon-readme !!
+   !! changes will be overwritten.                   !!
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+   !! source digest: sha256:dc29155c73a519d3732e2806f60bd11ebb31cd8c181ebd5918e4bc68080d37aa
+   !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
+
+.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
+    :target: https://odoo-community.org/page/development-status
+    :alt: Beta
+.. |badge2| image:: https://img.shields.io/badge/licence-LGPL--3-blue.png
+    :target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html
+    :alt: License: LGPL-3
+.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fserver--auth-lightgray.png?logo=github
+    :target: https://github.com/OCA/server-auth/tree/18.0/password_security
+    :alt: OCA/server-auth
+.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
+    :target: https://translation.odoo-community.org/projects/server-auth-18-0/server-auth-18-0-password_security
+    :alt: Translate me on Weblate
+.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-auth&target_branch=18.0
+    :alt: Try me on Runboat
+
+|badge1| |badge2| |badge3| |badge4| |badge5|
+
+This module allows admin to set company-level password security
+requirements and enforces them on the user.
+
+It contains features such as
+
+-  Password expiration days
+-  Password length requirement
+-  Password minimum number of lowercase letters
+-  Password minimum number of uppercase letters
+-  Password minimum number of numbers
+-  Password minimum number of special characters
+
+**Table of contents**
+
+.. contents::
+   :local:
+
+Configuration
+=============
+
+Navigate to General Settings under Configuration Scroll down to the
+``Password Policy`` section Set the policies to your liking.
+
+Password complexity requirements will be enforced upon next password
+change for any user in that company.
+
+**Settings & Defaults**
+
+These are defined at the company level:
+
+[TABLE]
+
+Usage
+=====
+
+Configure using above instructions for each company that should have
+password security mandates.
+
+Bug Tracker
+===========
+
+Bugs are tracked on `GitHub Issues <https://github.com/OCA/server-auth/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us to smash it by providing a detailed and welcomed
+`feedback <https://github.com/OCA/server-auth/issues/new?body=module:%20password_security%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+
+Do not contact contributors directly about support or help with technical issues.
+
+Credits
+=======
+
+Authors
+-------
+
+* LasLabs
+* Onestein
+* Kaushal Prajapati
+* Tecnativa
+* initOS GmbH
+* Omar Nasr
+
+Contributors
+------------
+
+-  James Foster <jfoster@laslabs.com>
+
+-  Dave Lasley <dave@laslabs.com>
+
+-  Kaushal Prajapati <kbprajapati@live.com>
+
+-  Petar Najman <petar.najman@modoolar.com>
+
+-  Shepilov Vladislav <shepilov.v@protonmail.com>
+
+-  Florian Kantelberg <florian.kantelberg@initos.com>
+
+-  Carlos Jimeno <carlos.jimeno@bt-group.com>
+
+-  Dhara Solanki <dhara.solanki@initos.com>
+
+-  `Open Source Integrators <https://opensourceintegrators.com>`__
+
+      -  Chandresh Thakkar <cthakkar@opensourceintegrators.com>
+      -  Daniel Reis <dreis@opensourceintegrators.com>
+
+-  `Onestein <https://www.onestein.nl>`__:
+
+   -  Andrea Stirpe <a.stirpe@onestein.nl>
+
+Maintainers
+-----------
+
+This module is maintained by the OCA.
+
+.. image:: https://odoo-community.org/logo.png
+   :alt: Odoo Community Association
+   :target: https://odoo-community.org
+
+OCA, or the Odoo Community Association, is a nonprofit organization whose
+mission is to support the collaborative development of Odoo features and
+promote its widespread use.
+
+This module is part of the `OCA/server-auth <https://github.com/OCA/server-auth/tree/18.0/password_security>`_ project on GitHub.
+
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

password_security/__init__.py

@@ -0,0 +1,5 @@
+# Copyright 2015 LasLabs Inc.
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).
+
+from .post_install import init_config_parameters
+from . import controllers, models

password_security/__manifest__.py

@@ -0,0 +1,34 @@
+# Copyright 2015 LasLabs Inc.
+# Copyright 2018 Modoolar <info@modoolar.com>.
+# Copyright 2019 initOS GmbH
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).
+{
+    "name": "Password Security",
+    "summary": "Allow admin to set password security requirements.",
+    "version": "18.0.1.0.0",
+    "author": "LasLabs, "
+    "Onestein, "
+    "Kaushal Prajapati, "
+    "Tecnativa, "
+    "initOS GmbH, "
+    "Omar Nasr, "
+    "Odoo Community Association (OCA)",
+    "category": "Base",
+    "depends": [
+        "auth_signup",
+        "auth_password_policy_signup",
+        "auth_totp",
+    ],
+    "website": "https://github.com/OCA/server-auth",
+    "license": "LGPL-3",
+    "data": [
+        "views/res_config_settings_views.xml",
+        "security/ir.model.access.csv",
+        "security/res_users_pass_history.xml",
+    ],
+    "demo": [
+        "demo/res_users.xml",
+    ],
+    "post_init_hook": "init_config_parameters",
+    "installable": True,
+}

password_security/controllers/__init__.py

@@ -0,0 +1,5 @@
+# Copyright 2015 LasLabs Inc.
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).
+
+from . import main
+from . import home

password_security/controllers/home.py

@@ -0,0 +1,23 @@
+# Copyright 2022 brain-tec AG (https://bt-group.com)
+# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).
+
+from odoo import http
+from odoo.http import request
+
+from odoo.addons.auth_totp.controllers.home import Home
+
+
+class PasswordSecurity2FAHome(Home):
+    @http.route()
+    def web_totp(self, redirect=None, **kwargs):
+        already_logged_in = request.session.uid
+        result = super().web_totp(redirect, **kwargs)
+        if already_logged_in or not (
+            request.session.uid and request.env.user._password_has_expired()
+        ):
+            return result
+        # My password is expired, kick me out
+        request.env.user.action_expire_password()
+        request.session.logout(keep_db=True)
+        redirect = request.env.user.partner_id._get_signup_url()
+        return request.redirect(redirect)

password_security/controllers/main.py

@@ -0,0 +1,63 @@
+# Copyright 2015 LasLabs Inc.
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).
+
+import logging
+
+from werkzeug.exceptions import BadRequest
+
+from odoo import http
+from odoo.http import request
+
+from odoo.addons.auth_signup.controllers.main import AuthSignupHome
+from odoo.addons.web.controllers.home import ensure_db
+
+_logger = logging.getLogger(__name__)
+
+
+class PasswordSecurityHome(AuthSignupHome):
+    def do_signup(self, qcontext):
+        password = qcontext.get("password")
+        user = request.env.user
+        user._check_password(password)
+        return super().do_signup(qcontext)
+
+    @http.route()
+    def web_login(self, *args, **kw):
+        ensure_db()
+        response = super().web_login(*args, **kw)
+        if not request.params.get("login_success"):
+            return response
+        if not request.env.user:
+            return response
+        # Now, I'm an authenticated user
+        # With 2FA there is a second step, and we would not be completely logged in
+        if not (request.session.uid and request.env.user._password_has_expired()):
+            return response
+        # My password is expired, kick me out
+        request.env.user.action_expire_password()
+        request.session.logout(keep_db=True)
+        # I was kicked out, so set login_success in request params to False
+        request.params["login_success"] = False
+        redirect = request.env.user.partner_id._get_signup_url()
+        return request.redirect(redirect)
+
+    @http.route()
+    def web_auth_signup(self, *args, **kw):
+        """Try to catch all the possible exceptions not already handled
+        in the parent method"""
+
+        try:
+            qcontext = self.get_auth_signup_qcontext()
+        except Exception:
+            raise BadRequest from None  # HTTPError: 400 Client Error: BAD REQUEST
+
+        try:
+            return super().web_auth_signup(*args, **kw)
+        except Exception as e:
+            # Here we catch any generic exception since UserError is already
+            # handled in parent method web_auth_signup()
+            qcontext["error"] = str(e)
+            response = request.render("auth_signup.signup", qcontext)
+            response.headers["X-Frame-Options"] = "SAMEORIGIN"
+            response.headers["Content-Security-Policy"] = "frame-ancestors 'self'"
+            return response

password_security/demo/res_users.xml

@@ -0,0 +1,9 @@
+<!--
+    Copyright 2016 LasLabs Inc.
+    License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).
+-->
+<odoo>
+    <record id="base.user_root" model="res.users">
+        <field name="password_write_date" eval="datetime.now()" />
+    </record>
+</odoo>