Skip to content

[18.0][MIG] user_log_view: Migration to 18.0#787

Closed
kobros-tech wants to merge 19 commits into
OCA:18.0from
kencove:18.0-mig-user_log_view
Closed

[18.0][MIG] user_log_view: Migration to 18.0#787
kobros-tech wants to merge 19 commits into
OCA:18.0from
kencove:18.0-mig-user_log_view

Conversation

@kobros-tech

Copy link
Copy Markdown
Contributor

from #711

@CasVissers-360ERP CasVissers-360ERP left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@kobros-tech

Copy link
Copy Markdown
Contributor Author

@mymage

@mymage

mymage commented Jun 19, 2025

Copy link
Copy Markdown
Member

@mymage

please force push so the runboat will be operative

@kobros-tech kobros-tech force-pushed the 18.0-mig-user_log_view branch from 9294bc4 to ec500fc Compare June 19, 2025 13:44
@jqbeltran2 jqbeltran2 mentioned this pull request Sep 2, 2025
23 tasks
@jqbeltran2

Copy link
Copy Markdown

This PR was missing in #698

@jqbeltran2

Copy link
Copy Markdown

Hi @kobros-tech

Is this still active?

@jqbeltran2

Copy link
Copy Markdown

/ocabot migration user_log_view

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Sorry @jqbeltran2 you are not allowed to mark the addon to be migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@luisDIXMIT luisDIXMIT left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and LGTM!!

<record id="action_user_log" model="ir.actions.act_window">
<field name="name">Authentication logs</field>
<field name="type">ir.actions.act_window</field>
<field name="res_model">res.users.log</field>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update tree → list

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jqbeltran2

not applied yet

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's solved in the new PR

</field>
</record>

<record id="res_users_log_view_tree" model="ir.ui.view">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@jqbeltran2

Copy link
Copy Markdown

Hi @kobros-tech

Could you please apply the suggested changes? Thanks!

@fernandahf

Copy link
Copy Markdown

@kobros-tech

Could you apply the technical comments, please?

cc @jqbeltran2

@etobella

Copy link
Copy Markdown
Member

@kobros-tech Can you review the comments?

@jqbeltran2

Copy link
Copy Markdown

I'm applying the changes

@jqbeltran2

Copy link
Copy Markdown

This PR seems abandoned, I've created #850 to apply missing comments

@pedrobaeza pedrobaeza closed this Oct 13, 2025
@kobros-tech

Copy link
Copy Markdown
Contributor Author

@jqbeltran2
@etobella
@fernandahf

Hi all, I am so sorry that I couldn't notice the notification the reason is that I subscriped to all repos. of OCA with all activity which made me unable to diiferentiate between the important emails concerning me and other general ones.

now I returned to the default, and it was a wise decision to solve and make the PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.