Skip to content

[19.0][IMP] auth_api_key: neutralize API keys#950

Open
yankinmax wants to merge 1 commit into
OCA:19.0from
camptocamp:neutralize-auth_api_key
Open

[19.0][IMP] auth_api_key: neutralize API keys#950
yankinmax wants to merge 1 commit into
OCA:19.0from
camptocamp:neutralize-auth_api_key

Conversation

@yankinmax

Copy link
Copy Markdown
Contributor

Clear stored auth_api_key secrets during database neutralization.

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall

Comment thread test-requirements.txt Outdated
@yankinmax yankinmax force-pushed the neutralize-auth_api_key branch from 5751015 to 2769e9f Compare June 12, 2026 06:32
@TDu

TDu commented Jun 12, 2026

Copy link
Copy Markdown
Member

It is already a feature in 18 https://github.com/OCA/server-auth/blob/18.0/auth_api_key/data/neutralize.sql should we not forward port ?

@yankinmax

Copy link
Copy Markdown
Contributor Author

It is already a feature in 18 https://github.com/OCA/server-auth/blob/18.0/auth_api_key/data/neutralize.sql should we not forward port ?

It's not exactly what we think about. @ivantodorovich what do you think?

@vvrossem

Copy link
Copy Markdown

It is already a feature in 18 https://github.com/OCA/server-auth/blob/18.0/auth_api_key/data/neutralize.sql should we not forward port ?

🤔 this would benefit #949: key would remain required

@ivantodorovich

This comment was marked as resolved.

@yankinmax yankinmax force-pushed the neutralize-auth_api_key branch from 2769e9f to b7b7c81 Compare June 15, 2026 07:25

@ivantodorovich ivantodorovich left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants