Skip to content

[18.0][FIX] password_security: enforce configured per-character-class count #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kwoychesko wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] password_security: enforce configured per-character-class count #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions password_security/models/res_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,10 +119,10 @@ def _check_password_rules(self, password):
pwd_params = self._get_all_password_params()
password_regex = [
"^",
"(?=.*?[a-z]){" + str(pwd_params["lower"]) + ",}",
"(?=.*?[A-Z]){" + str(pwd_params["upper"]) + ",}",
"(?=.*?\\d){" + str(pwd_params["numeric"]) + ",}",
r"(?=.*?[\W_]){" + str(pwd_params["special"]) + ",}",
"(?=(?:.*?[a-z]){" + str(pwd_params["lower"]) + ",})",
"(?=(?:.*?[A-Z]){" + str(pwd_params["upper"]) + ",})",
"(?=(?:.*?\\d){" + str(pwd_params["numeric"]) + ",})",
r"(?=(?:.*?[\W_]){" + str(pwd_params["special"]) + ",})",
".{%d,}$" % pwd_params["minlength"],
]
if not re.search("".join(password_regex), password):
Expand Down
11 changes: 11 additions & 0 deletions password_security/tests/test_res_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,17 @@ def test_underscore_is_special_character(self):
rec_id = self._new_record()
rec_id._check_password("asdQWE12345_3")

def test_check_password_enforces_class_count(self):
"""It should require the configured *count* of a character class"""
rec_id = self._new_record()
# Require two uppercase letters
self.env["ir.config_parameter"].sudo().set_param("password_security.upper", 2)
# Only one uppercase letter: must be rejected
with self.assertRaises(UserError):
rec_id._check_password("aSdqwe123$%^")
# Two uppercase letters: accepted
rec_id._check_password("aSDqwe123$%^")

def test_user_with_admin_rights_can_create_users(self):
demo = self.env.ref("base.user_demo")
demo.groups_id |= self.env.ref("base.group_erp_manager")
Expand Down
Loading