[MIG] base_user_role_company: Migration to 19.0

Author: Milan Topuzov

base_user_role_company/README.rst

@@ -1,3 +1,7 @@
+.. image:: https://odoo-community.org/readme-banner-image
+   :target: https://odoo-community.org/get-involved?utm_source=readme
+   :alt: Odoo Community Association
+
 =====================
 User roles by company
 =====================
@@ -13,17 +17,17 @@ User roles by company
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
     :target: https://odoo-community.org/page/development-status
     :alt: Beta
-.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
+.. |badge2| image:: https://img.shields.io/badge/license-AGPL--3-blue.png
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fserver--backend-lightgray.png?logo=github
-    :target: https://github.com/OCA/server-backend/tree/18.0/base_user_role_company
+    :target: https://github.com/OCA/server-backend/tree/19.0/base_user_role_company
     :alt: OCA/server-backend
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/server-backend-18-0/server-backend-18-0-base_user_role_company
+    :target: https://translation.odoo-community.org/projects/server-backend-19-0/server-backend-19-0-base_user_role_company
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-backend&target_branch=18.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-backend&target_branch=19.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -66,29 +70,29 @@ to all active companies will be activated.
 
 For example:
 
-- A "SALES PERSON" and a "SALES MANAGER" roles are created.
+-  A "SALES PERSON" and a "SALES MANAGER" roles are created.
 
-- A user is assigned to the roles:
+-  A user is assigned to the roles:
 
-  - "SALES PERSON", with no specific company assigned (meaning all)
-  - "SALES MANAGER" only to "My Company (Chicago)"
+   -  "SALES PERSON", with no specific company assigned (meaning all)
+   -  "SALES MANAGER" only to "My Company (Chicago)"
 
-- When selecting active companies from the UI widget:
+-  When selecting active companies from the UI widget:
 
-  - If only "My Company (San Francisco)" is active, "SALES PERSON" will
-    be active.
-  - If only "My Company (Chicago)" is active, "SALES PERSON" and "SALES
-    MANAGER" will be active.
-  - If both "My Company (San Francisco)" and "My Company (Chicago)" is
-    active, "SALES PERSON" will be active.
+   -  If only "My Company (San Francisco)" is active, "SALES PERSON"
+      will be active.
+   -  If only "My Company (Chicago)" is active, "SALES PERSON" and
+      "SALES MANAGER" will be active.
+   -  If both "My Company (San Francisco)" and "My Company (Chicago)" is
+      active, "SALES PERSON" will be active.
 
 Bug Tracker
 ===========
 
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/server-backend/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/server-backend/issues/new?body=module:%20base_user_role_company%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/server-backend/issues/new?body=module:%20base_user_role_company%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -105,17 +109,17 @@ Contributors
 
 `Open Source Integrators <http://opensourceintegrators.com>`__
 
-   - Daniel Reis <dreis@opensourceintegrators.com>
-   - Chandresh Thakkar <cthakkr@opensourceintegrators.com>
-   - Urvisha Desai <udesai@opensourceintegrators.com>
+   -  Daniel Reis <dreis@opensourceintegrators.com>
+   -  Chandresh Thakkar <cthakkr@opensourceintegrators.com>
+   -  Urvisha Desai <udesai@opensourceintegrators.com>
 
 `WeSolved <http://wesolved.com>`__
 
-   - Robin Conjour <rconjour@wesolved.com>
+   -  Robin Conjour <rconjour@wesolved.com>
 
 `Dynapps <http://dynapps.eu>`__
 
-   - Bert Van Groenendael <bert.vangroenendael@dynapps.eu>
+   -  Bert Van Groenendael <bert.vangroenendael@dynapps.eu>
 
 Maintainers
 -----------
@@ -130,6 +134,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/server-backend <https://github.com/OCA/server-backend/tree/18.0/base_user_role_company>`_ project on GitHub.
+This module is part of the `OCA/server-backend <https://github.com/OCA/server-backend/tree/19.0/base_user_role_company>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

base_user_role_company/__manifest__.py

@@ -3,7 +3,7 @@
 
 {
     "name": "User roles by company",
-    "version": "18.0.1.0.2",
+    "version": "19.0.1.0.0",
     "category": "Tools",
     "author": "Open Source Integrators, Odoo Community Association (OCA)",
     "license": "AGPL-3",

base_user_role_company/controllers/main.py

@@ -8,9 +8,10 @@
 
 class HomeExtended(Home):
     @http.route()
-    def web_load_menus(self, unique):
-        response = super().web_load_menus(unique)
+    def web_load_menus(self, *args, **kwargs):
+        response = super().web_load_menus(*args, **kwargs)
         # On logout & re-login we could see wrong menus being rendered
         # To avoid this, menu http cache must be disabled
-        response.headers.remove("Cache-Control")
+        # Using .pop() as Werkzeug Headers no longer supports __delitem__ (del)
+        response.headers.pop("Cache-Control", None)
         return response

base_user_role_company/models/ir_http.py

@@ -8,13 +8,13 @@
 class IrHttp(models.AbstractModel):
     _inherit = "ir.http"
 
-    def session_info(self):
+    def session_info(self, *args, **kwargs):
         """
         Based on the selected companies (cids),
         calculate the roles to enable.
         A role should be enabled only when it applies to all selected companies.
         """
-        result = super().session_info()
+        result = super().session_info(*args, **kwargs)
         if self.env.user.role_line_ids:
             cids_str = request.httprequest.cookies.get("cids", str(self.env.company.id))
             cids = [int(cid) for cid in cids_str.split("-")]

base_user_role_company/models/role.py

@@ -28,15 +28,15 @@ def _check_company(self):
                 raise ValidationError(
                     self.env._(
                         'User "%(user)s" does not have access to the company '
-                        '"%(company)s"'
+                        '"%(company)s"',
+                        user=record.user_id.name,
+                        company=record.company_id.name,
                     )
-                    % {"user": record.user_id.name, "company": record.company_id.name}
                 )
 
-    _sql_constraints = [
-        (
-            "user_role_uniq",
-            "unique (user_id,role_id,company_id)",
-            "Roles can be assigned to a user only once at a time",
-        )
-    ]
+    # Override parent unique constraint to allow the same role multiple times
+    # for a user, provided company_id differs.
+    _user_role_uniq = models.Constraint(
+        "UNIQUE (user_id, role_id, company_id)",
+        "Roles can be assigned to a user only once at a time",
+    )

base_user_role_company/models/user.py

@@ -7,20 +7,18 @@
 class ResUsers(models.Model):
     _inherit = "res.users"
 
-    @classmethod
-    def authenticate(cls, db, credential, user_agent_env):
-        auth_info = super().authenticate(db, credential, user_agent_env)
-        # On login, ensure the proper roles are applied
-        # The last Role applied may not be the correct one,
-        # sonce the new session current company can be different
-        with cls.pool.cursor() as cr:
-            env = api.Environment(cr, auth_info["uid"], {})
+    def authenticate(self, *args, **kwargs):
+        auth_info = super().authenticate(*args, **kwargs)
+        # Ensure proper roles are applied for the logged-in user
+        uid = auth_info.get("uid") if isinstance(auth_info, dict) else None
+        if uid:
+            env = api.Environment(self.env.cr, uid, {})
             if env.user.role_line_ids:
                 env.user.set_groups_from_roles()
         return auth_info
 
-    def _get_enabled_roles(self):
-        res = super()._get_enabled_roles()
+    def _get_enabled_roles(self, *args, **kwargs):
+        res = super()._get_enabled_roles(*args, **kwargs)
         if self.role_line_ids:
             active_roles = self.env["res.users.role.line"]
             if self.env.context.get("active_company_ids"):
@@ -32,8 +30,9 @@ def _get_enabled_roles(self):
                     active_roles |= role_line
                 elif role_line.company_id.id in company_ids:
                     role_line_companies = self.role_line_ids.filtered(
-                        lambda x, rl=role_line: x.role_id == rl.role_id
-                        and x.company_id.id in company_ids
+                        lambda x, rl=role_line: (
+                            x.role_id == rl.role_id and x.company_id.id in company_ids
+                        )
                     )
                     if len(role_line_companies) == len(company_ids):
                         active_roles |= role_line

base_user_role_company/static/description/index.html

@@ -3,7 +3,7 @@
 <head>
 <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
 <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" />
-<title>User roles by company</title>
+<title>README.rst</title>
 <style type="text/css">
 
 /*
@@ -360,16 +360,21 @@
 </style>
 </head>
 <body>
-<div class="document" id="user-roles-by-company">
-<h1 class="title">User roles by company</h1>
+<div class="document">
 
+
+<a class="reference external image-reference" href="https://odoo-community.org/get-involved?utm_source=readme">
+<img alt="Odoo Community Association" src="https://odoo-community.org/readme-banner-image" />
+</a>
+<div class="section" id="user-roles-by-company">
+<h1>User roles by company</h1>
 <!-- !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:22170e229c468ec41046141f10de50f397080458a7de6004f4a453721c02ca2f
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/server-backend/tree/18.0/base_user_role_company"><img alt="OCA/server-backend" src="https://img.shields.io/badge/github-OCA%2Fserver--backend-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/server-backend-18-0/server-backend-18-0-base_user_role_company"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/server-backend&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/license-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/server-backend/tree/19.0/base_user_role_company"><img alt="OCA/server-backend" src="https://img.shields.io/badge/github-OCA%2Fserver--backend-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/server-backend-19-0/server-backend-19-0-base_user_role_company"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/server-backend&amp;target_branch=19.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Enable User Roles depending on the Companies selected.</p>
 <p>A company specific Role will only be enabled if it is set for <strong>all</strong>
 the currently selected companies.</p>
@@ -391,7 +396,7 @@ <h1 class="title">User roles by company</h1>
 </ul>
 </div>
 <div class="section" id="configuration">
-<h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-1">Configuration</a></h2>
 <p>Roles are set on the User form.</p>
 <p>The “Company” additional column allows to set a Role as only valid for
 specific companies.</p>
@@ -400,7 +405,7 @@ <h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
 selection rules.</p>
 </div>
 <div class="section" id="usage">
-<h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-2">Usage</a></h2>
 <p>Select the active companies from the web client widget, near the top
 right corner. When doing so, the User’s security Groups are recomputed,
 based on the Roles.</p>
@@ -415,34 +420,34 @@ <h1><a class="toc-backref" href="#toc-entry-2">Usage</a></h1>
 </ul>
 </li>
 <li>When selecting active companies from the UI widget:<ul>
-<li>If only “My Company (San Francisco)” is active, “SALES PERSON” will
-be active.</li>
-<li>If only “My Company (Chicago)” is active, “SALES PERSON” and “SALES
-MANAGER” will be active.</li>
+<li>If only “My Company (San Francisco)” is active, “SALES PERSON”
+will be active.</li>
+<li>If only “My Company (Chicago)” is active, “SALES PERSON” and
+“SALES MANAGER” will be active.</li>
 <li>If both “My Company (San Francisco)” and “My Company (Chicago)” is
 active, “SALES PERSON” will be active.</li>
 </ul>
 </li>
 </ul>
 </div>
 <div class="section" id="bug-tracker">
-<h1><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-3">Bug Tracker</a></h2>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/server-backend/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/server-backend/issues/new?body=module:%20base_user_role_company%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/server-backend/issues/new?body=module:%20base_user_role_company%0Aversion:%2019.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
-<h1><a class="toc-backref" href="#toc-entry-4">Credits</a></h1>
+<h2><a class="toc-backref" href="#toc-entry-4">Credits</a></h2>
 <div class="section" id="authors">
-<h2><a class="toc-backref" href="#toc-entry-5">Authors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-5">Authors</a></h3>
 <ul class="simple">
 <li>Open Source Integrators</li>
 </ul>
 </div>
 <div class="section" id="contributors">
-<h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-6">Contributors</a></h3>
 <p><a class="reference external" href="http://opensourceintegrators.com">Open Source Integrators</a></p>
 <blockquote>
 <ul class="simple">
@@ -465,18 +470,19 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
 </blockquote>
 </div>
 <div class="section" id="maintainers">
-<h2><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h2>
+<h3><a class="toc-backref" href="#toc-entry-7">Maintainers</a></h3>
 <p>This module is maintained by the OCA.</p>
 <a class="reference external image-reference" href="https://odoo-community.org">
 <img alt="Odoo Community Association" src="https://odoo-community.org/logo.png" />
 </a>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-backend/tree/18.0/base_user_role_company">OCA/server-backend</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-backend/tree/19.0/base_user_role_company">OCA/server-backend</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>
 </div>
+</div>
 </body>
 </html>

base_user_role_company/tests/__init__.py

@@ -1,2 +1,3 @@
 from . import test_role_per_company
 from . import test_use_only_enabled_roles
+from . import test_load_menus

base_user_role_company/tests/test_load_menus.py

@@ -0,0 +1,14 @@
+# Copyright 2026 Open Source Integrators
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
+
+from odoo.tests.common import HttpCase
+
+
+class LoadMenusTests(HttpCase):
+    def setUp(self):
+        super().setUp()
+        self.authenticate("admin", "admin")
+
+    def test_load_menus(self):
+        "Expect no errors on HomeExtended.web_load_menus controller"
+        self.url_open("/web/webclient/load_menus")