[18.0][MIG] base_external_system: Migration to 18.0

[NL66278]

The module base_external_system will be the base for other modules to be migrated:

• base_external_system_http
• base_external_system_ms_client_assertion
• base_external_system_oauth
• base_external_system_odoorpc

[tendil]

@NL66278 could you please do a rebase? Thank you!

[NL66278]

The original contents of the PR where a full migration of the improved 16.0 version, that unfortunately was never merged. Now that the unimproved 16.0 version has been merged into 18.0, I freshly reïmplemented the 16.0 improvements.

[Kiplangatdan]

@NL66278 There are some obsolete files no longer used, otherwise this looks good:
../models/external_system_os.py
../tests/test_external_system_os.py

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[NL66278]

@NL66278 There are some obsolete files no longer used, otherwise this looks good: ../models/external_system_os.py ../tests/test_external_system_os.py

@Kiplangatdan Those files are really not there. Maybe in your working directory, but not in the PR. Please have another look.

[Kiplangatdan]

@NL66278 There are some obsolete files no longer used, otherwise this looks good: ../models/external_system_os.py ../tests/test_external_system_os.py

@Kiplangatdan Those files are really not there. Maybe in your working directory, but not in the PR. Please have another look.

@NL66278 It doesn't show in the PR because they were never touched:

https://github.com/Therp/server-backend/blob/18.0-mig-base_external_system/base_external_system/models/external_system_os.py

https://github.com/Therp/server-backend/blob/18.0-mig-base_external_system/base_external_system/tests/test_external_system_os.py

[NL66278]

@Kiplangatdan Ah, I got confused because this was originally part of a migration branch. Files have now been removed.

[thomaspaulb]

/ocabot migration base_external_system

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-447-by-thomaspaulb-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 06081b2. Thanks a lot for contributing to OCA. ❤️