Skip to content

[19.0][MIG] server_action_domain#1286

Open
JordiBForgeFlow wants to merge 11 commits into
OCA:19.0from
ForgeFlow:19.0-mig-server_action_domain
Open

[19.0][MIG] server_action_domain#1286
JordiBForgeFlow wants to merge 11 commits into
OCA:19.0from
ForgeFlow:19.0-mig-server_action_domain

Conversation

@JordiBForgeFlow

Copy link
Copy Markdown
Member

Standard migration

@OCA-git-bot OCA-git-bot added series:19.0 mod:server_action_domain Module server_action_domain labels Apr 29, 2026

@CristianoMafraJunior CristianoMafraJunior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JordiBForgeFlow

Copy link
Copy Markdown
Member Author

/ocabit merge nobump

1 similar comment
@pedrobaeza

Copy link
Copy Markdown
Member

/ocabit merge nobump

@DavidJForgeFlow
DavidJForgeFlow force-pushed the 19.0-mig-server_action_domain branch from 13661f6 to 304ac58 Compare May 19, 2026 07:25
@DavidJForgeFlow

Copy link
Copy Markdown
Contributor

@JordiBForgeFlow @pedrobaeza @CristianoMafraJunior please review again, I only removed default "[]" as it was causing a bug when trying to opening print/server action dropdown:
image

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot migration server_action_domain

@OCA-git-bot OCA-git-bot added this to the 19.0 milestone May 19, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request May 19, 2026
30 tasks

@dnplkndll dnplkndll left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@CristianoMafraJunior CristianoMafraJunior left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion: When using BaseCommon, there’s no need to redefine cls.env with tracking_disable=True, as these are already handled in BaseCommon.

@classmethod
def setUpClass(cls):
super().setUpClass()
cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.