[19.0][MIG] server_action_mass_edit_onchange: Migration to 19.0#1310
Open
MohamedOsman7 wants to merge 4 commits into
Open
[19.0][MIG] server_action_mass_edit_onchange: Migration to 19.0#1310MohamedOsman7 wants to merge 4 commits into
MohamedOsman7 wants to merge 4 commits into
Conversation
5bf90f7 to
4c720e6
Compare
…mp fields removals
4c720e6 to
9890c9c
Compare
Author
|
@trisdoan can you please make a review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
server_action_mass_edit_onchangefrom 18.0 to 19.0This PR migrates the module to 19.0. The module extends
server_action_mass_editto optionally play a field's onchange methods before writing the value during a mass edit.Changes
19.0.1.0.0.points are still compatible with 19.0:
mass.editing.wizard._exec_write()override still matches the base signature.server_action_mass_edit.view_server_action_formand theapply_domainfield it attaches to still exist.play_onchanges()is still provided byonchange_helper(server-tools).res.partner:Partnerclass was renamed toResPartner.emailno longer has an onchange method. The negative test case (a field withapply_onchanges=Falsemust not trigger its onchange) now usescompany_type/onchange_company_typeinstead ofemail/onchange_email, preserving the original test intent.Testing
TestMassEditingWithOnChange.test_wizard_field_onchangepasses on 19.0 (verified locally,0 failed, 0 error(s)).