Skip to content

Commit 16e3baa

Browse files
committed
Fix resource_view and showcase to check required fields on create path only in create_in_hdx
1 parent 01e9611 commit 16e3baa

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

src/hdx/data/resource_view.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,9 @@ def create_in_hdx(self, **kwargs: Any) -> None:
164164
Returns:
165165
None
166166
"""
167-
if "ignore_check" not in kwargs: # allow ignoring of field checks
168-
self.check_required_fields()
169167
if not self._update_resource_view(log=True, **kwargs):
168+
if "ignore_check" not in kwargs: # allow ignoring of field checks
169+
self.check_required_fields()
170170
self._save_to_hdx("create", "title")
171171

172172
def delete_from_hdx(self) -> None:

src/hdx/data/showcase.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,19 +129,17 @@ def create_in_hdx(self, **kwargs: Any) -> None:
129129
Returns:
130130
None
131131
"""
132-
if "ignore_check" not in kwargs: # allow ignoring of field checks
133-
self.check_required_fields()
134132
if "name" in self.data and self._load_from_hdx("showcase", self.data["name"]):
135133
logger.warning(f"{'showcase'} exists. Updating {self.data['name']}")
136134
merge_two_dictionaries(self.data, self._old_data)
137135
self.clean_tags()
138136
self._hdx_update("showcase", "name", force_active=True, **kwargs)
139137
else:
138+
if "ignore_check" not in kwargs: # allow ignoring of field checks
139+
self.check_required_fields()
140140
self.clean_tags()
141141
self._save_to_hdx("create", "title", force_active=True)
142142

143-
self._create_in_hdx("showcase", "name", "title", **kwargs)
144-
145143
def delete_from_hdx(self) -> None:
146144
"""Deletes a showcase from HDX.
147145

0 commit comments

Comments
 (0)