Add resource download function

Author: mcarans

hdx/data/hdxobject.py

@@ -84,7 +84,7 @@ def update_from_json(self, path: str):
 
     def _read_from_hdx(self, object_type: str, value: str, fieldname: Optional[str] = 'id',
                        action: Optional[str] = None,
-                       **kwargs) -> Union[Tuple[bool, dict], Tuple[bool, str]]:
+                       **kwargs) -> Tuple[bool, Union[dict, str]]:
         """Makes a read call to HDX passing in given parameter.
 
         Args:
@@ -95,7 +95,7 @@ def _read_from_hdx(self, object_type: str, value: str, fieldname: Optional[str]
             **kwargs: Other fields to pass to CKAN.
 
         Returns:
-            (bool, dict/str): (True/False, HDX object metadata/Error)
+            Tuple[bool, Union[dict, str]]: (True/False, HDX object metadata/Error)
         """
         if not value:
             raise HDXError("Empty %s value!" % object_type)

hdx/data/resource.py

@@ -5,7 +5,7 @@
 import logging
 import os
 from os.path import join
-from typing import Optional, List
+from typing import Optional, List, Tuple
 
 from hdx.configuration import Configuration
 from hdx.utilities.downloader import download_file
@@ -160,14 +160,14 @@ def delete_datastore(self) -> None:
         if not success:
             logger.debug(result)
 
-    def download(self, path: Optional[str] = None) -> (str, str):
-        """Download resource store in provided path or named temporary file if no path given
+    def download(self, path: Optional[str] = None) -> Tuple[str, str]:
+        """Download resource store to provided path or named temporary file if no path given
 
         Args:
             path (str): Path to download resource to. Defaults to None.
 
         Returns:
-            (str, str): (URL downloaded, Path of downloaded file)
+            Tuple[str, str]: (URL downloaded, Path to downloaded file)
 
         """
         # Download the resource