pass no_empty

Author: mcarans

src/hdx/data/dataset.py

@@ -2506,8 +2506,9 @@ def process_row(row: Sequence | Mapping) -> Sequence | Mapping | None:
             format=format,
             encoding=encoding,
             row_function=process_row,
+            no_empty=no_empty,
         )
-        if not rows and no_empty:
+        if not rows:
             logger.error(f"No data rows in {filename}!")
             return False, retdict
         if yearcol is not None or date_function is not None:

tests/hdx/data/test_dataset_resource_generation.py

@@ -500,6 +500,23 @@ def process_year(row):
                 )
                 assert success is False
                 url = "https://raw.githubusercontent.com/OCHA-DAP/hdx-python-api/main/tests/fixtures/gen_resource/test_data_no_data.csv"
+                success, results = dataset.download_generate_resource(
+                    downloader,
+                    url,
+                    folder,
+                    filename,
+                    resourcedata,
+                )
+                assert success is False
+                success, results = dataset.download_generate_resource(
+                    downloader,
+                    url,
+                    folder,
+                    filename,
+                    resourcedata,
+                    no_empty=False,
+                )
+                assert success is True
                 success, results = dataset.download_generate_resource(
                     downloader,
                     url,