Skip to content
This repository was archived by the owner on Jul 6, 2022. It is now read-only.

Commit 5a68527

Browse files
authored
fix Connect-To bug (#41)
* replace internal coverage tools with PSCoverage (#39) * use PSCoverage instead of internal module * remove internal pscoverage ref * remove deprecated and internal coverage module * fix dependency test for conection types without deps * - tests should return true for missing deps (fixes #40) * remove pre release counter * change prerelease tag
1 parent dbf53b7 commit 5a68527

6 files changed

Lines changed: 10 additions & 184 deletions

File tree

appveyor.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ image: Visual Studio 2017
2424

2525
install:
2626
- ps: Import-Module .\tools\AppVeyor.psm1
27-
- ps: Import-Module .\tools\CoverallsIO.psm1
2827
- ps: Invoke-InstallDependencies
2928

3029
environment:

src/PSCredentialStore.psd1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
ReleaseNotes = 'This is a pre-release version!. Do not use in production!'
123123

124124
# Prerelease string of this module
125-
Prerelease = 'alpha1'
125+
Prerelease = 'preview'
126126

127127
# Flag to indicate whether the module requires explicit user acceptance for install/update
128128
# RequireLicenseAcceptance = $false

src/Private/Resolve-Dependency.ps1

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@ function Resolve-Dependency {
7070

7171
process {
7272
$SelectedDependency = $Dependency.Optional | Where-Object {$_.Name -match $Name}
73+
# return true if there is no dependency defined
74+
if ($null -eq $SelectedDependency) {
75+
return $true
76+
}
77+
7378
$res = @()
7479
foreach ($Module in $SelectedDependency.Modules) {
7580
$res += Test-Module -Name $Module

tests/Private/01_Resolve-Dependency.Tests.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ Describe "Resolve-Dependency" {
1919
{ Resolve-Dependency -Name 'awesome'} | Should -Not -Throw
2020
}
2121

22-
It "Missing dependency file should return false" {
23-
Resolve-Dependency -Name 'awesome' | Should -Be $false
22+
It "Missing dependency file should return true" {
23+
Resolve-Dependency -Name 'awesome' | Should -Be $true
2424
}
2525
}
2626
Context "Testing input variations" {

tools/AppVeyor.psm1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@ Function Invoke-InstallDependencies() {
2121
Import-PackageProvider -Name NuGet -RequiredVersion '2.8.5.208' -Force
2222
Install-Module -Name 'Pester' -Scope CurrentUser -RequiredVersion '4.4.2' -Force -SkipPublisherCheck -AllowClobber
2323
Install-Module -Name 'posh-git' -Scope CurrentUser -RequiredVersion '1.0.0-beta2' -Force -SkipPublisherCheck -AllowClobber -AllowPrerelease
24-
# Install-Module -Name 'PSCoverage' -Scope CurrentUser -Force -SkipPublisherCheck -AllowClobber
25-
Import-Module -Name 'Pester', 'posh-git' #, 'PSCoverage'
24+
Install-Module -Name 'PSCoverage' -Scope CurrentUser -Force -SkipPublisherCheck -AllowClobber -RequiredVersion '1.0.78'
25+
Import-Module -Name 'Pester', 'posh-git' , 'PSCoverage'
2626
}
2727
Catch {
2828
$MsgParams = @{

tools/CoverallsIO.psm1

Lines changed: 0 additions & 178 deletions
This file was deleted.

0 commit comments

Comments
 (0)