[REPLACED] fix: Misc ohif-downstream integration test failures

[wayfarer3130]

Being replaced by individual changes for some of this.

Miscellaneous ohif-downstream integration test failures

No functional changes

Context

Changes & Results

Update to grid comparison for 3D tests

What are the effects of this change?

• Before vs After
• Screenshots / GIFs / Videos
  -->

Testing

Checklist

PR

• [] My Pull Request title is descriptive, accurate and follows the
  semantic-release format and guidelines.

Code

• [] My code has been well-documented (function documentation, inline comments,
  etc.)

Public Documentation Updates

• [] The documentation page has been updated as necessary for any public API
  additions or removals.

Tested Environment

• [] OS:
• [] Node version:
• [] Browser:

Greptile Summary

This PR fixes flaky downstream integration test failures in the 3D viewport tests by scoping the screenshot comparison from the full page to only the viewport-grid element (via viewportPageObject.grid). Updated baseline screenshots are included to match the new comparison area.

• tests/3DFourUp.spec.ts & tests/3DMain.spec.ts: viewportPageObject fixture added to the test destructuring; the second argument to checkForScreenshot changed from page (full-page screenshot) to viewportPageObject.grid (data-testid="viewport-grid" locator). Test names updated with a "grid compare" suffix to reflect the change.
• Baseline PNGs updated: Both threeDFourUpDisplayedCorrectly.png and threeDMainDisplayedCorrectly.png regenerated to match the narrowed comparison region.
• The PR description states "No functional changes", but this change does meaningfully narrow the screenshot comparison area — it now ignores toolbar/sidebar chrome that may render differently across environments, which is intentional and desirable.
• The ViewportPageObject.grid getter correctly returns this.page.getByTestId('viewport-grid'), which is a valid Locator | Page input for checkForScreenshot, so there are no type or runtime concerns.

Confidence Score: 5/5

• This PR is safe to merge — all changes are confined to test files and baseline screenshots with no production code impact.
• The change is minimal: two test specs and two PNG baselines. The fix correctly scopes screenshot comparison to the viewport grid locator (viewportPageObject.grid) which is already defined and properly typed in ViewportPageObject.ts. The checkForScreenshot utility accepts Locator | Page so the call is type-correct. No application logic is touched.
• No files require special attention.

Important Files Changed

Filename	Overview
tests/3DFourUp.spec.ts	Adds viewportPageObject fixture and changes screenshot comparison from full-page (page) to the viewport grid locator; test name updated to reflect "grid compare" intent.
tests/3DMain.spec.ts	Same pattern as 3DFourUp.spec.ts — viewport grid locator replaces page for the screenshot target and test name updated; no logic issues found.
tests/screenshots/chromium/3DFourUp.spec.ts/threeDFourUpDisplayedCorrectly.png	Baseline screenshot updated to match the new, narrower viewport-grid scope rather than the full page.
tests/screenshots/chromium/3DMain.spec.ts/threeDMainDisplayedCorrectly.png	Baseline screenshot updated to match the new viewport-grid scope; binary diff expected and correct.

Sequence Diagram

sequenceDiagram
    participant Test as 3D Spec Test
    participant Fixture as Playwright Fixture
    participant VP as ViewportPageObject
    participant Check as checkForScreenshot
    participant Expect as expect(locator)

    Test->>Fixture: destructure { page, mainToolbarPageObject, viewportPageObject }
    Fixture-->>Test: viewportPageObject = new ViewportPageObject(page)

    Test->>VP: viewportPageObject.grid
    VP-->>Test: page.getByTestId("viewport-grid") [Locator]

    Note over Test: Before fix: checkForScreenshot(page, page, path)<br/>After fix: checkForScreenshot(page, viewportPageObject.grid, path)

    Test->>Check: checkForScreenshot(page, gridLocator, screenshotPath)
    Check->>Expect: expect(gridLocator).toHaveScreenshot(path, options)
    Expect-->>Check: pass / fail (scoped to viewport-grid only)
    Check-->>Test: true or throws

Loading

_{Last reviewed commit: "fix: Misc ohif-downs..."}

[netlify]

✅ Deploy Preview for ohif-dev ready!

Name	Link
🔨 Latest commit	ed33fb3
🔍 Latest deploy log	https://app.netlify.com/projects/ohif-dev/deploys/69cd2c053387590008fbc497
😎 Deploy Preview	https://deploy-preview-5907--ohif-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[cypress]

Viewers    Run #6138

Run Properties:   Passed #6138  •  ed33fb3592: Update bun

Project	Viewers
Branch Review	fix/cs3d-combined-integration
Run status	Passed #6138
Run duration	02m 17s
Commit	ed33fb3592: Update bun
Committer	Bill Wallace
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	37
View all changes introduced in this branch ↗︎

[wayfarer3130]

This test waits for the images to render after loading - so it can be really fast if stuff is in cache, but can wait quite a while on slow systems, rather than using a fixed delay and just hoping it works.

[wayfarer3130]

@GhadeerAlbattarni - this file has changes to prevent updating viewports that haven't been otherwise changed - it allows rendering the gray part of the image area on the 3d four up spec test.

[wayfarer3130]

@GhadeerAlbattarni - I think you need this file too.

[wayfarer3130]

@GhadeerAlbattarni - this is some testing for the changes.

[wayfarer3130]

And this fixes the hyrdation so that it loads the viewports clicking "load", otherwise those don't get applied.

@GhadeerAlbattarni

[wayfarer3130]

@GhadeerAlbattarni - I think you need this bit to notify the viewports they need to render.