feat: Update to use pnpm#6031
Open
wayfarer3130 wants to merge 12 commits into
Open
Conversation
…le extensions and modes. Update package.json scripts for development and production builds, and adjust webpack configuration files to accommodate new plugin imports and settings.
…cing compatibility and performance. Refactor webpack configuration in multiple extensions and modes to utilize the new library structure for UMD output. Adjust package.json scripts and settings for improved build processes.
…m Webpack to Rspack v2, the shift to pnpm workspaces, and the increase in minimum Node.js version to 24. Include new build commands, plugin replacements, and updates to package configurations across the monorepo.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sedghi
reviewed
May 20, 2026
| fi | ||
| echo "::notice::Cloning CS3D from $REPO branch $BRANCH" | ||
| git clone --depth 1 --branch "$BRANCH" "$REPO" libs/@cornerstonejs | ||
| cache: pnpm |
Member
There was a problem hiding this comment.
please make sure these are intentional, i don't understand why playwright should change as a result of pnpm
sedghi
reviewed
May 20, 2026
| "npm": ">=6", | ||
| "yarn": ">=1.16.0" | ||
| "node": ">=24", | ||
| "pnpm": ">=10" |
sedghi
reviewed
May 20, 2026
| "Colorbars" | ||
| ] | ||
| ], | ||
| "liveServer.settings.port": 5501 |
sedghi
reviewed
May 20, 2026
| const config = { | ||
| mode: isProdBuild ? 'production' : 'development', | ||
| devtool: isProdBuild ? 'source-map' : 'cheap-module-source-map', | ||
| devtool: isProdBuild ? 'hidden-source-map' : 'cheap-module-source-map', |
Member
There was a problem hiding this comment.
is this expected? why hidden-source-map? can we document this change in migrations
sedghi
reviewed
May 20, 2026
| }, | ||
| "devDependencies": { | ||
| "cross-env": "7.0.3", | ||
| "webpack": "5.105.0", |
Member
There was a problem hiding this comment.
i guess we don't need webpack anymore
sedghi
reviewed
May 20, 2026
| }, | ||
| "devDependencies": { | ||
| "cross-env": "7.0.3", | ||
| "webpack": "5.105.0", |
sedghi
reviewed
May 20, 2026
| "license": "MIT", | ||
| "repository": "OHIF/Viewers", | ||
| "main": "dist/ohif-mode-microscopy.umd.js", | ||
| "module": "src/index.tsx", |
Member
There was a problem hiding this comment.
do we need module? i don't think so
sedghi
reviewed
May 20, 2026
| "license": "MIT", | ||
| "repository": "OHIF/Viewers", | ||
| "main": "dist/ohif-mode-ultrasound-pleura-bline.umd.js", | ||
| "module": "src/index.ts", |
Member
There was a problem hiding this comment.
some extensions/packages has index.ts as module some not, i remember module is really made up thing by bundlers
sedghi
reviewed
May 20, 2026
| "workbox-webpack-plugin": "6.6.1" | ||
| } | ||
| }, | ||
| "productVersion": "3.4.0", |
sedghi
reviewed
May 20, 2026
| "npm": ">=6", | ||
| "yarn": ">=1.18.0" | ||
| "node": ">=24", | ||
| "pnpm": ">=10" |
sedghi
reviewed
May 20, 2026
| const warmupStudyInstanceUID = '1.3.6.1.4.1.14519.5.2.1.1706.8374.643249677828306008300337414785'; | ||
| const warmupTimeout = 180_000; | ||
|
|
||
| export default async function globalSetup(config: FullConfig) { |
sedghi
reviewed
May 20, 2026
|
|
||
| RUN apt-get update && apt-get install -y build-essential python3 | ||
|
|
||
| RUN npm install -g pnpm@latest |
sedghi
reviewed
May 20, 2026
| @@ -1,5 +0,0 @@ | |||
| { | |||
| "version": "3.13.0-beta.79", | |||
sedghi
reviewed
May 20, 2026
| @@ -1,85 +0,0 @@ | |||
| { | |||
sedghi
reviewed
May 20, 2026
| "worker-loader": "3.0.8" | ||
| }, | ||
| "optionalDependencies": { | ||
| "@percy/cypress": "3.1.6", |
Member
There was a problem hiding this comment.
we don't use percy, we can remove
sedghi
reviewed
May 20, 2026
| @@ -1,34 +0,0 @@ | |||
| console.log('preinstall.js'); | |||
sedghi
reviewed
May 20, 2026
Member
sedghi
left a comment
sedghi
left a comment
There was a problem hiding this comment.
please see my comments, we should merge cs3d pnpm first
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment