IMAP protocol parser, logger and sticky buffers#14792
Conversation
This introduces a parser for IMAP protocol. Ticket OISF#8276
This introduces a logger for IMAP protocol. Ticket OISF#8276
This implement the following sticky buffers for IMAP protocol: - imap.request - imap.response - imap.email.direction - imap.email.header - imap.email.header.name - imap.email.header.value - imap.email.body Ticket OISF#8276
|
NOTE: This PR may contain new authors. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14792 +/- ##
==========================================
+ Coverage 82.15% 82.17% +0.02%
==========================================
Files 1003 1006 +3
Lines 263674 265642 +1968
==========================================
+ Hits 216610 218292 +1682
- Misses 47064 47350 +286
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 29540 |
jasonish
left a comment
There was a problem hiding this comment.
I sent you some pcaps the other day that showed an issue with the body.
I also think we need to align as much as we can with the email object we already have at the top level. Something like...
If its generic to smtp, imap, etc.. It should go in the email object. If its specific to imap, then it goes in the imap object.
|
Replaced with #14822 |
Should |
Maybe indeed |
Link to ticket: https://redmine.openinfosecfoundation.org/issues/8276
Describe changes:
This is how an IMAP event looks like:
Sticky buffers added:
Doc updated
SV_BRANCH=OISF/suricata-verify#2908