Skip to content

Ftp max tx comment in suricata.yaml and rule for ftp.too_many_transactions event#15213

Closed
alinse-pltzr wants to merge 2 commits into
OISF:mainfrom
alinse-pltzr:ftp-max-tx-comment-and-rule
Closed

Ftp max tx comment in suricata.yaml and rule for ftp.too_many_transactions event#15213
alinse-pltzr wants to merge 2 commits into
OISF:mainfrom
alinse-pltzr:ftp-max-tx-comment-and-rule

Conversation

@alinse-pltzr
Copy link
Copy Markdown

@alinse-pltzr alinse-pltzr commented Apr 15, 2026

Background:

Describe changes:

  • added max-tx to ftp section in app layer of suricata.yaml.in
  • added rule to generate 'ftp.too_many_transactions` event

SV_BRANCH: OISF/suricata-verify#3037

@alinse-pltzr alinse-pltzr requested a review from a team as a code owner April 15, 2026 19:32
Copy link
Copy Markdown
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution :)

Could you please edit your PR description to add an SV branch in the format as seen here: #15209 (otherwise, the CI checks won't pick it up).

Also, please have a look at our guidelines for commit messages, and adjust them accordingly :)

https://docs.suricata.io/en/latest/devguide/contributing/code-submission-process.html#commits

@jlucovsky
Copy link
Copy Markdown
Contributor

jlucovsky commented Apr 16, 2026

These changes are fine; however, the FTP parser isn't generating the "too many transactions" event. I'll create a ticket for that: https://redmine.openinfosecfoundation.org/issues/8489

@victorjulien victorjulien added the needs verify Needs (a) Suricata-verify test(s) label Apr 17, 2026
Copy link
Copy Markdown
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this is fine, but is is missing the ftp-parser generating the event so that the rule can trigger

@jlucovsky
Copy link
Copy Markdown
Contributor

Do you mind if I cherry-pick your commits into a PR that also raises the event?

@alinse-pltzr
Copy link
Copy Markdown
Author

alinse-pltzr commented Apr 24, 2026

Do you mind if I cherry-pick your commits into a PR that also raises the event?

No, I m ok with that :) thanks for adding the event

@catenacyber
Copy link
Copy Markdown
Contributor

Superseded by #15292

@catenacyber catenacyber closed this May 6, 2026
@alinse-pltzr alinse-pltzr deleted the ftp-max-tx-comment-and-rule branch May 13, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs verify Needs (a) Suricata-verify test(s)

Development

Successfully merging this pull request may close these issues.

5 participants