feat: add comprehensive logging diagnostics for random number generation, sleepy updates, and frame tracking.

Author: Okladnoj

CRCLogs2/DiagLog.txt

@@ -70,6 +70,7 @@
 
 	void addCRCDebugLine(const char *fmt, ...);
 	void addCRCDebugLineNoCounter(const char *fmt, ...);
+	void addCRCRandomLine(const char *fmt, ...);
 	void addCRCDumpLine(const char *fmt, ...);
 	void addCRCGenLine(const char *fmt, ...);
 	#define CRCDEBUG_LOG(x) addCRCDebugLine x
@@ -100,6 +101,7 @@
 	extern AsciiString g_saveDebugCRCPerFrameDir;
 
 	extern Bool g_logObjectCRCs;
+	extern Bool g_logRandom;
 
 #else // DEBUG_CRC
 

CRCLogs2/RegDiag.txt

@@ -286,13 +286,13 @@ class SimpleProfiler
 #endif
 
 // #define DEBUG_BUILDMAPCACHE_FLAG
-// #define DEBUG_INFO_MAC_FLAG
+#define DEBUG_INFO_MAC_FLAG
 // #define DEBUG_FILESYSTEM_MAC_FLAG
 // #define DEBUG_RENDER_CORE_MAC_FLAG
 #define DEBUG_NETWORK_MAC_FLAG
 // #define DEBUG_AUTH_MAC_FLAG
 // #define DEBUG_EAC_MAC_FLAG
-// #define DEBUG_LOG_FLAG_V2
+#define DEBUG_LOG_FLAG_V2
 #define DEBUG_SETTINGS_MAC_FLAG
 
 #ifdef DEBUG_BUILDMAPCACHE_FLAG

CRCLogs2/SleepyDiag.txt

@@ -114,6 +114,8 @@ Int lastCRCDebugFrame = 0;
 Int lastCRCDebugIndex = 0;
 extern Bool inCRCGen;
 
+static void outputCRCDebugLinesPerFrame();
+
 void CRCDebugStartNewGame()
 {
 	if (TheGameLogic->isInShellGame())
@@ -131,9 +133,21 @@ void CRCDebugStartNewGame()
 		FilenameList::iterator it;
 		for (it = files.begin(); it != files.end(); ++it)
 		{
-			DeleteFile(it->str());
+			// TheSuperHackers @fix Preserve the pre-game log (InitRandom, etc.)
+			// if it was already created in an earlier phase of the current startup sequence.
+			if (strstr(it->str(), "-00001") == nullptr)
+			{
+				DeleteFile(it->str());
+			}
 		}
 	}
+
+	if (numDebugStrings > 0)
+	{
+		lastCRCDebugFrame = -1;
+		outputCRCDebugLinesPerFrame();
+	}
+
 	nextDebugString = 0;
 	numDebugStrings = 0;
 	lastCRCDebugFrame = 0;
@@ -251,6 +265,40 @@ void addCRCDebugLineNoCounter(const char *fmt, ...)
     va_end(args);
 }
 
+void addCRCRandomLine(const char *fmt, ...)
+{
+    va_list args;
+    va_start(args, fmt);
+    
+	if (lastCRCDebugFrame != (TheGameLogic ? TheGameLogic->getFrame() : -1))
+	{
+		outputCRCDebugLinesPerFrame();
+		lastCRCDebugFrame = (TheGameLogic ? TheGameLogic->getFrame() : -1);
+		lastCRCDebugIndex = 0;
+	}
+
+	DebugStrings[nextDebugString][0] = 0;
+	Int len = 0;
+
+	vsnprintf(DebugStrings[nextDebugString]+len, MaxStringLen-len, fmt, args);
+
+	char *tmp = DebugStrings[nextDebugString];
+	while (tmp && *tmp)
+	{
+		if (*tmp == '\r' || *tmp == '\n')
+			*tmp = ' ';
+		++tmp;
+	}
+
+	++nextDebugString;
+	++numDebugStrings;
+	if (nextDebugString == MaxStrings)
+		nextDebugString = 0;
+
+    va_end(args);
+}
+
+
 void addCRCGenLine(const char *fmt, ...)
 {
 	if (!(IS_FRAME_OK_TO_LOG))

Core/GameEngine/Include/Common/CRCDebug.h

@@ -32,6 +32,7 @@
 #include "Common/RandomValue.h"
 #include "Common/crc.h"
 #include "Common/Debug.h"
+#include "Common/CRCDebug.h"
 #include "GameLogic/GameLogic.h"
 
 #undef DEBUG_RANDOM_AUDIO
@@ -115,6 +116,9 @@ void InitRandom()
 
 void InitRandom( UnsignedInt seed )
 {
+#ifdef DEBUG_CRC
+	CRCGEN_LOG(("InitRandom called with seed: %u", seed));
+#endif
 #ifdef DETERMINISTIC
 	seed = 0;
 #endif
@@ -124,6 +128,10 @@ void InitRandom( UnsignedInt seed )
 	seedRandom(seed, theGameLogicSeed);
 	theGameLogicBaseSeed = seed;
 
+if (g_logRandom)
+	{
+		addCRCRandomLine("InitRandom %08lx", seed);
+	}
 #ifdef DEBUG_RANDOM_LOGIC
 	DEBUG_LOG(("InitRandom %08lx", seed));
 #endif
@@ -280,6 +288,10 @@ Int GetGameLogicRandomValue( int lo, int hi, const char *file, int line )
 
 	const Int rval = ((Int)(randomValue(theGameLogicSeed) % delta)) + lo;
 
+if (g_logRandom)
+	{
+		addCRCRandomLine("%d: GetGameLogicRandomValue = %d (%d - %d), %s line %d", TheGameLogic ? TheGameLogic->getFrame() : -1, rval, lo, hi, file, line);
+	}
 #ifdef DEBUG_RANDOM_LOGIC
 	DEBUG_LOG(( "%d: GetGameLogicRandomValue = %d (%d - %d), %s line %d",
 		TheGameLogic->getFrame(), rval, lo, hi, file, line ));
@@ -307,6 +319,10 @@ Real GetGameLogicRandomValueReal( Real lo, Real hi, const char *file, int line )
 
 	const Real rval = ((Real)(randomValue(theGameLogicSeed)) * theMultFactor) * delta + lo;
 
+if (g_logRandom)
+	{
+		addCRCRandomLine("%d: GetGameLogicRandomValueReal = %f, %s line %d", TheGameLogic ? TheGameLogic->getFrame() : -1, rval, file, line);
+	}
 #ifdef DEBUG_RANDOM_LOGIC
 	DEBUG_LOG(( "%d: GetGameLogicRandomValueReal = %f, %s line %d",
 		TheGameLogic->getFrame(), rval, file, line ));
@@ -337,6 +353,10 @@ Int GetGameLogicRandomValueUnchanged( int lo, int hi, const char *file, int line
 	const UnsignedInt delta = hi - lo + 1;
 	const Int rval = ((Int)(randomValue(seed) % delta)) + lo;
 
+if (g_logRandom)
+	{
+		addCRCRandomLine("%d: GetGameLogicRandomValueUnchanged = %d (%d - %d), %s line %d", TheGameLogic ? TheGameLogic->getFrame() : -1, rval, lo, hi, file, line);
+	}
 #ifdef DEBUG_RANDOM_LOGIC
 	DEBUG_LOG(( "%d: GetGameLogicRandomValueUnchanged = %d (%d - %d), %s line %d",
 		TheGameLogic->getFrame(), rval, lo, hi, file, line ));
@@ -367,6 +387,10 @@ Real GetGameLogicRandomValueRealUnchanged( Real lo, Real hi, const char *file, i
 	const Real delta = hi - lo;
 	const Real rval = ((Real)(randomValue(seed)) * theMultFactor) * delta + lo;
 
+if (g_logRandom)
+	{
+		addCRCRandomLine("%d: GetGameLogicRandomValueRealUnchanged = %f, %s line %d", TheGameLogic ? TheGameLogic->getFrame() : -1, rval, file, line);
+	}
 #ifdef DEBUG_RANDOM_LOGIC
 	DEBUG_LOG(( "%d: GetGameLogicRandomValueRealUnchanged = %f, %s line %d",
 		TheGameLogic->getFrame(), rval, file, line ));

Core/GameEngine/Include/Common/Debug.h

@@ -331,7 +331,11 @@ void LANAPI::update()
 {
 	if (LANbuttonPushed)
 		return;
+#ifdef __APPLE__
+	static const UnsignedInt LANAPIUpdateDelay = 33;
+#else
 	static const UnsignedInt LANAPIUpdateDelay = 200;
+#endif
 	UnsignedInt now = timeGetTime();
 
 	if (now > m_lastUpdate + LANAPIUpdateDelay)

Core/GameEngine/Source/Common/CRCDebug.cpp

@@ -189,6 +189,21 @@ void LANAPI::OnGameStart()
 
 	if (m_currentGame)
 	{
+#ifdef __APPLE__
+		printf("MAC_LANAPI: === OnGameStart === amIHost=%d, localSlot=%d, seed=%u\n",
+			m_currentGame->amIHost(), m_currentGame->getLocalSlotNum(), m_currentGame->getSeed());
+		for (Int dbgSlot = 0; dbgSlot < MAX_SLOTS; ++dbgSlot)
+		{
+			GameSlot *dbgS = m_currentGame->getSlot(dbgSlot);
+			if (dbgS && dbgS->isOccupied())
+			{
+				printf("MAC_LANAPI:   Slot %d: human=%d, ai=%d, playerTemplate=%d, color=%d, startPos=%d, team=%d, IP=0x%08X\n",
+					dbgSlot, dbgS->isHuman(), dbgS->isAI(), dbgS->getPlayerTemplate(),
+					dbgS->getColor(), dbgS->getStartPos(), dbgS->getTeamNumber(), dbgS->getIP());
+			}
+		}
+		fflush(stdout);
+#endif
 		LANPreferences pref;
 		AsciiString option;
 		option.format("%d", m_currentGame->getLANSlot( m_currentGame->getLocalSlotNum() )->getPlayerTemplate());
@@ -340,6 +355,11 @@ void LANAPI::OnGameOptions( UnsignedInt playerIP, Int playerSlot, AsciiString op
 		// Parse player requests (side, color, etc)
 		if( AmIHost() && m_localIP != playerIP)
 		{
+#ifdef __APPLE__
+			printf("MAC_LANAPI: [HOST] received options from slot %d (IP=0x%08X): \"%s\"\n",
+				playerSlot, playerIP, options.str());
+			fflush(stdout);
+#endif
 			if (options.compare("HELLO") == 0)
 			{
 				m_currentGame->setPlayerLastHeard(playerSlot, timeGetTime());
@@ -466,6 +486,12 @@ void LANAPI::OnGameOptions( UnsignedInt playerIP, Int playerSlot, AsciiString op
 					DEBUG_LOG(("Slot value is color=%d, PlayerTemplate=%d, startPos=%d, team=%d",
 						slot->getColor(), slot->getPlayerTemplate(), slot->getStartPos(), slot->getTeamNumber()));
 					DEBUG_LOG(("Slot list updated to %s", GenerateGameOptionsString().str()));
+#ifdef __APPLE__
+					printf("MAC_LANAPI: [HOST] applied change for slot %d: color=%d, playerTemplate=%d, startPos=%d, team=%d\n",
+						playerSlot, slot->getColor(), slot->getPlayerTemplate(), slot->getStartPos(), slot->getTeamNumber());
+					printf("MAC_LANAPI: [HOST] broadcasting: %s\n", GenerateGameOptionsString().str());
+					fflush(stdout);
+#endif
 				}
 			}
 		}
@@ -523,6 +549,11 @@ void LANAPI::OnGameJoin( ReturnType ret, LANGameInfo *theGame )
 
 		LANPreferences pref;
 		AsciiString options;
+#ifdef __APPLE__
+		printf("MAC_LANAPI: OnGameJoin OK: preferredFaction=%d, preferredColor=%d\n",
+			pref.getPreferredFaction(), pref.getPreferredColor());
+		fflush(stdout);
+#endif
 		options.format("PlayerTemplate=%d", pref.getPreferredFaction());
 		RequestGameOptions(options, true);
 		options.format("Color=%d", pref.getPreferredColor());

Core/GameEngine/Source/Common/RandomValue.cpp

@@ -706,6 +706,13 @@ void LANAPI::handleChat( LANMessage *msg, UnsignedInt senderIP )
 
 void LANAPI::handleGameStart( LANMessage *msg, UnsignedInt senderIP )
 {
+#ifdef __APPLE__
+	printf("MAC_LANAPI: handleGameStart RECEIVED from %08X, inLobby=%d, hasGame=%d, hostIP=%08X, inProgress=%d\n",
+		senderIP, m_inLobby, m_currentGame != nullptr,
+		m_currentGame ? m_currentGame->getIP(0) : 0,
+		m_currentGame ? m_currentGame->isGameInProgress() : -1);
+	fflush(stdout);
+#endif
 	if (!m_inLobby && m_currentGame && m_currentGame->getIP(0) == senderIP && !m_currentGame->isGameInProgress())
 	{
 		OnGameStart();