Skip to content

Commit f8f016d

Browse files
authored
Merge pull request #19 from ONS-Innovation/TotalDwarf03-patch-1
Bug: get_codeowner_users had explicit reference to ONSDigital. Replac…
2 parents f3e5158 + fc42f02 commit f8f016d

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

github_api_toolkit/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -463,7 +463,7 @@ def get_team_maintainers(self, org: str, team_name: str) -> list | tuple:
463463
else:
464464
return self.get_error_message(response)
465465

466-
def get_codeowner_users(self, codeowners: list) -> list:
466+
def get_codeowner_users(self, org: str, codeowners: list) -> list:
467467
"""Gets a list of users from a list of users and teams. Will get the maintainers of any teams and add them as a user.
468468
469469
Args:
@@ -477,7 +477,7 @@ def get_codeowner_users(self, codeowners: list) -> list:
477477

478478
for codeowner in codeowners:
479479
if codeowner["type"] == "team":
480-
team_maintainers = self.get_team_maintainers("ONSDigital", codeowner["name"])
480+
team_maintainers = self.get_team_maintainers(org, codeowner["name"])
481481

482482
for maintainer in team_maintainers:
483483
users.append(maintainer["login"])
@@ -531,8 +531,8 @@ def get_repository_email_list(self, org: str, repo: str, branch: str = "main") -
531531

532532
codeowners = self.identify_teams_and_users(codeowners)
533533

534-
codeowners = self.get_codeowner_users(codeowners)
534+
codeowners = self.get_codeowner_users(org, codeowners)
535535

536536
emails = self.get_codeowner_emails(codeowners, org)
537537

538-
return emails
538+
return emails

0 commit comments

Comments
 (0)