add whitespace

Author: delterr

README.md

@@ -328,34 +328,41 @@ terraform destroy -var-file=env/dev/dev.tfvars
 ### Deployments with Concourse
 
 #### Allowlisting your IP
+
 To setup the deployment pipeline with concourse, you must first allowlist your IP address on the Concourse
 server. IP addresses are flushed everyday at 00:00 so this must be done at the beginning of every working day
 whenever the deployment pipeline needs to be used. Follow the instructions on the Confluence page (SDP Homepage > SDP Concourse > Concourse Login) to
 login. All our pipelines run on sdp-pipeline-prod, whereas sdp-pipeline-dev is the account used for
 changes to Concourse instance itself. Make sure to export all necessary environment variables from sdp-pipeline-prod (AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, AWS_SESSION_TOKEN).
 
 #### Setting up a pipeline
+
 When setting up our pipelines, we use ecs-infra-user on sdp-dev to be able to interact with our infrastructure on AWS. The credentials for this are stored on
 AWS Secrets Manager so you do not need to set up anything yourself.
 
 To set the pipeline, run the following script:
+
 ```bash
 chmod u+x ./concourse/scripts/set_pipeline.sh
 ./concourse/scripts/set_pipeline.sh github-repo-archive-script
 ```
+
 Note that you only have to run chmod the first time running the script in order to give permissions.
 This script will set the branch and pipeline name to whatever branch you are currently on. It will also set the image tag on ECR to the current commit hash at the time of setting the pipeline.
 
 The pipeline name itself will usually follow a pattern as follows: `<repo-name>-<branch-name>`
 If you wish to set a pipeline for another branch without checking out, you can run the following:
+
 ```bash
 ./concourse/scripts/set_pipeline.sh github-repo-archive-script <branch_name>
 ```
 
 If the branch you are deploying is "main" or "master", it will trigger a deployment to the sdp-prod environment. To set the ECR image tag, you must draft a Github release pointing to the latest release of the main/master branch that has a tag in the form of vX.Y.Z. Drafting up a release will automatically deploy the latest version of the main/master branch with the associated release tag, but you can also manually trigger a build through the Concourse UI or the terminal prompt.
 
 #### Triggering a pipeline
+
 Once the pipeline has been set, you can manually trigger a build on the Concourse UI, or run the following command:
+
 ```bash
 fly -t aws-sdp trigger-job -j github-repo-archive-script-<branch-name>/build-and-push
 ```

concourse/scripts/assume_role.sh

@@ -8,9 +8,8 @@ aws sts assume-role --output text \
     --role-session-name concourse-pipeline-run \
     --query "Credentials.[AccessKeyId,SecretAccessKey,SessionToken]" \
     | awk -F '\t' '{print $1 > ("AccessKeyId")}{print $2 > ("SecretAccessKey")}{print $3 > ("SessionToken")}'
-# shellcheck disable=SC3040,SC2154
-
 
+# shellcheck disable=SC3040,SC2154
 AWS_ACCESS_KEY_ID="$(cat AccessKeyId)"
 AWS_SECRET_ACCESS_KEY="$(cat SecretAccessKey)"
 AWS_SESSION_TOKEN="$(cat SessionToken)"

concourse/scripts/build_image.sh

@@ -5,13 +5,17 @@ set -euo pipefail
 export STORAGE_DRIVER=vfs
 export PODMAN_SYSTEMD_UNIT=concourse-task
 
+# shellcheck disable=SC2154
 container_image=$(echo "$secrets" | jq -r .container_image)
 
 # shellcheck disable=SC2154
 aws ecr get-login-password --region eu-west-2 | podman --storage-driver=vfs login --username AWS --password-stdin "${aws_account_id}".dkr.ecr.eu-west-2.amazonaws.com
 
+# shellcheck disable=SC2154
 podman build -t "${container_image}":"${tag}" resource-repo
 
+# shellcheck disable=SC2154
 podman tag "${container_image}":"${tag}" "${aws_account_id}".dkr.ecr.eu-west-2.amazonaws.com/"${container_image}":"${tag}"
+
+# shellcheck disable=SC2154
 podman push "${aws_account_id}".dkr.ecr.eu-west-2.amazonaws.com/"${container_image}":"${tag}"
-# shellcheck disable=SC2154

concourse/scripts/set_pipeline.sh

@@ -5,7 +5,8 @@ repo_name=${1}
 if [[ $# -gt 1 ]]; then
     branch=${2}
     git rev-parse --verify "${branch}"
-    if [[ $? -ne 0 ]]; then # shellcheck disable=SC2181
+    # shellcheck disable=SC2181
+    if [[ $? -ne 0 ]]; then
         echo "Branch \"${branch}\" does not exist"
         exit 1
     fi
@@ -26,4 +27,3 @@ else
 fi
 
 fly -t aws-sdp set-pipeline -c concourse/ci.yml -p "${repo_name}"-"${branch}" -v branch="${branch}" -v tag="${tag}" -v env="${env}"
-

concourse/scripts/terraform_infra.sh

@@ -29,7 +29,8 @@ AWS_SECRET_ACCESS_KEY=$aws_secret_access_key
 export AWS_ACCESS_KEY_ID
 export AWS_SECRET_ACCESS_KEY
 
-git config --global url."https://x-access-token:$github_access_token@github.com/".insteadOf "https://github.com/" # shellcheck disable=
+# shellcheck disable=SC2086
+git config --global url."https://x-access-token:$github_access_token@github.com/".insteadOf "https://github.com/"
 
 if [[ ${env} != "prod" ]]; then
     env="dev"
@@ -39,6 +40,7 @@ cd resource-repo/terraform/service
 
 terraform init -backend-config=env/"${env}"/backend-"${env}".tfbackend -reconfigure
 
+# shellcheck disable=SC2154
 terraform apply \
 -var "aws_account_id=$aws_account_id" \
 -var "aws_access_key_id=$aws_access_key_id" \
@@ -54,4 +56,3 @@ terraform apply \
 -var "lambda_memory=$lambda_memory" \
 -var "schedule=$schedule" \
 -auto-approve
-# shellcheck disable=SC2154