Skip to content

Commit 71a482a

Browse files
authored
Merge pull request #12 from ONS-Innovation/KEH-674-5
KEH-674 + KEH-675 | Fix Terraform Linting Errors
2 parents f5a9057 + a80f256 commit 71a482a

5 files changed

Lines changed: 10 additions & 6 deletions

File tree

.checkov.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ skip-check:
1111
- CKV_AWS_158
1212
- CKV_AWS_338
1313

14+
# Pin module sources to a commit hash (false positive)
15+
- CKV_TF_1
16+
1417
# These ignores are TEMPORARY. They will be resolved in the future.
1518
- CKV_AWS_108
16-
- CKV_TF_1
17-
- CKV_TF_2
18-
- CKV_AWS_115
1919
- CKV_AWS_272

.github/workflows/mega-linter.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,8 @@ jobs:
8585

8686
# You can override MegaLinter flavor used to have faster performances
8787
# More info at https://megalinter.io/latest/flavors/
88-
uses: oxsecurity/megalinter@1fc052d03c7a43c78fe0fee19c9d648b749e0c01
88+
# The below commit hash is v8.8.0
89+
uses: oxsecurity/megalinter@e08c2b05e3dbc40af4c23f41172ef1e068a7d651
8990

9091
id: ml
9192

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,4 @@ megalint: ## Run the mega-linter.
5353
docker run --platform linux/amd64 --rm \
5454
-v /var/run/docker.sock:/var/run/docker.sock:rw \
5555
-v $(shell pwd):/tmp/lint:rw \
56-
oxsecurity/megalinter:v7
56+
oxsecurity/megalinter:v8

terraform/service/eventbridge.tf

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
module "eventbridge" {
2-
source = "terraform-aws-modules/eventbridge/aws"
2+
source = "terraform-aws-modules/eventbridge/aws"
3+
version = "4.1.0"
34

45
role_name = "${var.lambda_name}-eventbridge-role"
56

terraform/service/main.tf

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ resource "aws_lambda_function" "lambda_function" {
4343

4444
memory_size = var.lambda_memory
4545

46+
reserved_concurrent_executions = 100
47+
4648
role = aws_iam_role.lambda_function_role.arn
4749

4850
environment {

0 commit comments

Comments
 (0)