KEH-674 + KEH-675 | Fix Terraform Linting Errors

[TotalDwarf03]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

What

In this PR, I will remove the follow linting errors from being excluded and address them properly:

• CKV_AWS_115: Add a concurrent execution limit.
• CKV_AWS_TF1/2: Pin remote Terraform modules to a particular GitHub commit. This is more secure than using an AWS TF Registry release.

Testing

Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.

• Yes
• No
  Please write a brief description of why test coverage is not necessary here.
• Not as part of this ticket. (Could be done at a later point)

Documentation

Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.

• Yes
• No
  Please write a brief description of why documentation is not necessary here.
• Not as part of this ticket. (Could be done at a later point)

Related issues

KEH-674 + KEH-675 (Jira)

How to review

Linting should pass if this PR is successful.

[github-actions]

🦙 MegaLinter status: ⚠️ WARNING

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
⚠️ BASH	bash-exec	4		2	0	0.02s
✅ BASH	shellcheck	4		0	0	0.14s
✅ BASH	shfmt	4		0	0	0.01s
✅ CSHARP	csharpier	1		0	0	0.69s
✅ DOCKERFILE	hadolint	1		0	0	0.14s
✅ JSON	jsonlint	1		0	0	0.25s
✅ JSON	prettier	1		0	0	0.56s
✅ JSON	v8r	1		0	0	4.13s
✅ MARKDOWN	markdownlint	11		0	0	1.0s
✅ MARKDOWN	markdown-table-formatter	11		0	0	0.33s
✅ REPOSITORY	checkov	yes		no	no	25.55s
✅ REPOSITORY	dustilock	yes		no	no	0.01s
✅ REPOSITORY	gitleaks	yes		no	no	3.86s
✅ REPOSITORY	grype	yes		no	no	45.99s
✅ REPOSITORY	kics	yes		no	no	39.85s
✅ REPOSITORY	secretlint	yes		no	no	1.01s
✅ REPOSITORY	syft	yes		no	no	3.24s
✅ REPOSITORY	trivy	yes		no	no	12.09s
✅ REPOSITORY	trivy-sbom	yes		no	no	0.49s
✅ TERRAFORM	terraform-fmt	6		0	0	0.47s
✅ YAML	prettier	8		0	0	0.66s
✅ YAML	v8r	8		0	0	8.63s
✅ YAML	yamllint	8		0	0	0.53s

See detailed report in MegaLinter reports

You could have same capabilities but better runtime performances if you request a new MegaLinter flavor.

• Click here to request the new flavor

MegaLinter is graciously provided by OX Security

[mwirikia]

This was raised as a false positive - bridgecrewio/checkov#6354. The tool itself checkov makes use of version for modules.