KEH 2447 | Tagging to Image Digest

[co-opsw]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

What

Change the versioning for the image from tags to image digesr

Testing

Have any new tests been added as part of this issue? If not, try to explain why test coverage is not needed here.

• Yes
• No
  Please write a brief description of why test coverage is not necessary here.
• Not as part of this ticket. (Could be done at a later point)

Documentation

Has any new documentation been written as part of this issue? We should try to keep documentation up to date
as new code is added, rather than leaving it for the future.

• Yes
• No
  Please write a brief description of why documentation is not necessary here.
• Not as part of this ticket. (Could be done at a later point)

Related issues

KEH-2447

How to review

Check code, check deployment

[github-actions]

✅⚠️MegaLinter analysis: Success with warnings

Descriptor	Linter	Files	Fixed	Errors	Warnings	Elapsed time
✅ ACTION	zizmor	3		0	0	1.31s
⚠️ BASH	bash-exec	5		3	0	0.04s
✅ BASH	shellcheck	5		0	0	0.26s
✅ BASH	shfmt	5		0	0	0.02s
✅ CSHARP	csharpier	1		0	0	0.82s
✅ DOCKERFILE	hadolint	1		0	0	0.32s
✅ JSON	jsonlint	1		0	0	0.18s
✅ JSON	prettier	1		0	0	0.48s
✅ JSON	v8r	1		0	0	2.33s
✅ MARKDOWN	markdownlint	11		0	0	2.84s
✅ MARKDOWN	markdown-table-formatter	11		0	0	1.62s
✅ REPOSITORY	checkov	yes		no	no	27.21s
✅ REPOSITORY	dustilock	yes		no	no	0.05s
✅ REPOSITORY	gitleaks	yes		no	no	8.73s
✅ REPOSITORY	grype	yes		no	no	54.58s
✅ REPOSITORY	kingfisher	yes		no	no	8.37s
✅ REPOSITORY	osv-scanner	yes		no	no	0.61s
✅ REPOSITORY	secretlint	yes		no	no	1.23s
✅ REPOSITORY	syft	yes		no	no	3.18s
✅ REPOSITORY	trivy	yes		no	no	12.49s
✅ REPOSITORY	trivy-sbom	yes		no	no	0.6s
✅ TERRAFORM	terraform-fmt	6		0	0	0.76s
✅ YAML	prettier	8		0	0	0.61s
✅ YAML	v8r	8		0	0	7.77s
✅ YAML	yamllint	8		0	0	0.67s

Detailed Issues

⚠️ BASH / bash-exec - 3 errors

Results of bash-exec linter (version 5.3.3)
See documentation on https://megalinter.io/9.5.0/descriptors/bash_bash_exec/
-----------------------------------------------

❌ [ERROR] concourse/scripts/assume_role.sh
    Error: File:[concourse/scripts/assume_role.sh] is not executable

✅ [SUCCESS] concourse/scripts/build_image.sh
✅ [SUCCESS] concourse/scripts/set_pipeline.sh
❌ [ERROR] concourse/scripts/terraform_infra.sh
    Error: File:[concourse/scripts/terraform_infra.sh] is not executable

❌ [ERROR] shell_scripts/md_fix.sh
    Error: File:[shell_scripts/md_fix.sh] is not executable

Notices

📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining SECURITY_SUGGESTIONS: false)

See detailed reports in MegaLinter artifacts

Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)

• Documentation: Custom Flavors
• Command: npx mega-linter-runner@9.5.0 --custom-flavor-setup --custom-flavor-linters ACTION_ZIZMOR,BASH_EXEC,BASH_SHELLCHECK,BASH_SHFMT,CSHARP_CSHARPIER,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,REPOSITORY_CHECKOV,REPOSITORY_DUSTILOCK,REPOSITORY_GITLEAKS,REPOSITORY_GRYPE,REPOSITORY_OSV_SCANNER,REPOSITORY_SECRETLINT,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_KINGFISHER,TERRAFORM_TERRAFORM_FMT,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R

MegaLinter is graciously provided by OX Security
Show us your support by starring ⭐ the repository

[TotalDwarf03]

Consider other PR feedback.

Looks fine otherwise

[co-opsw]

Consider other PR feedback.

Looks fine otherwise

DL does not seem to have these as outputs. Are we fine not doing this, as these can be accessed within AWS?

[TotalDwarf03]

Consider other PR feedback.
Looks fine otherwise

DL does not seem to have these as outputs. Are we fine not doing this, as these can be accessed within AWS?

Discussed offline. Continuing without.