Merge pull request #33 from ONS-Innovation/fix-secret-manager-iam-resources

TotalDwarf03 · web-flow · commit 2e011827cf82 · 2025-11-25T17:00:07.000Z
Fix IAM Secret Manager Resource
diff --git a/terraform/lambda/main.tf b/terraform/lambda/main.tf
@@ -72,7 +72,7 @@ resource "aws_iam_role_policy" "lambda_additional_permissions" {
         Action = [
           "secretsmanager:GetSecretValue"
         ]
-        Resource = "arn:aws:secretsmanager:eu-west-2:${var.aws_account_id}:secret:${var.domain}-${var.service_subdomain}/secrets*"
+        Resource = data.terraform_remote_state.secrets.outputs.secret_arn
       },
       {
         Effect = "Allow"

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ resource "aws_iam_role_policy" "lambda_additional_permissions" {`
`72`	`72`	`Action = [`
`73`	`73`	`"secretsmanager:GetSecretValue"`
`74`	`74`	`]`
`75`		`- Resource = "arn:aws:secretsmanager:eu-west-2:${var.aws_account_id}:secret:${var.domain}-${var.service_subdomain}/secrets*"`
	`75`	`+ Resource = data.terraform_remote_state.secrets.outputs.secret_arn`
`76`	`76`	`},`
`77`	`77`	`{`
`78`	`78`	`Effect = "Allow"`