Drain thread pool and increase test time

Author: ospfranco

cpp/DBHostObject.cpp

@@ -236,12 +236,16 @@ void DBHostObject::create_jsi_functions(jsi::Runtime &rt) {
 
   function_map["close"] = HFN(this) {
     invalidated = true;
-
+    // Drain any in-flight async queries before closing the db handle.
+    // Without this, a queued/running execute() on the thread pool may
+    // dereference the freed sqlite3* pointer → heap corruption / SIGABRT.
+    thread_pool->waitFinished();
 #ifdef OP_SQLITE_USE_LIBSQL
     opsqlite_libsql_close(db);
 #else
     opsqlite_close(db);
 #endif
+    db = nullptr;
 
     return {};
   });
@@ -671,7 +675,13 @@ void DBHostObject::invalidate() {
   }
 
   invalidated = true;
-  thread_pool->restartPool();
+  // Drain in-flight thread pool work before closing the db handle.
+  // restartPool() joins threads (waiting for the current task) but then
+  // needlessly re-creates the pool. waitFinished() is sufficient: it
+  // blocks until the queue is empty and no worker is busy, then the
+  // ThreadPool destructor (via shared_ptr release) joins the threads.
+  thread_pool->waitFinished();
+
 #ifdef OP_SQLITE_USE_LIBSQL
   opsqlite_libsql_close(db);
 #else

example/src/App.tsx

@@ -7,7 +7,7 @@ import {
 } from '@op-engineering/op-test';
 import './tests'; // import all tests to register them
 import {SafeAreaProvider, SafeAreaView} from 'react-native-safe-area-context';
-import {performanceTest} from './performance_test';
+// import {performanceTest} from './performance_test';
 import {StyleSheet, Text, View} from 'react-native';
 import {open} from '@op-engineering/op-sqlite';
 
@@ -35,15 +35,15 @@ export default function App() {
         setServerResults(false);
       }
 
-      setTimeout(() => {
-        try {
-          global?.gc?.();
-          let perfRes = performanceTest();
-          setPerfResult(perfRes);
-        } catch (e) {
-          // intentionally left blank
-        }
-      }, 1000);
+      // setTimeout(() => {
+      //   try {
+      //     global?.gc?.();
+      //     let perfRes = performanceTest();
+      //     setPerfResult(perfRes);
+      //   } catch (e) {
+      //     // intentionally left blank
+      //   }
+      // }, 1000);
     };
 
     work();

scripts/poll-in-app-server.js

@@ -2,8 +2,8 @@ const http = require('http');
 
 async function pollInAppServer() {
   const startTime = Date.now();
-  const maxDuration = 5 * 60 * 1000; // 3 minutes - tests can take time on CI
-  const pollInterval = 5000; //
+  const maxDuration = 10 * 60 * 1000;
+  const pollInterval = 10000; //
 
   // Do an initial ping into the server