Thread pool fix

ospfranco · ospfranco · commit dcb272339bb3 · 2026-03-14T10:38:06.000+01:00
diff --git a/cpp/OPThreadPool.cpp b/cpp/OPThreadPool.cpp
@@ -74,10 +74,14 @@ void ThreadPool::doWork() {
 
       task = workQueue.front();
       workQueue.pop();
+      ++busy;
     }
-    ++busy;
     task();
-    --busy;
+    {
+      std::lock_guard<std::mutex> g(workQueueMutex);
+      --busy;
+    }
+    workQueueConditionVariable.notify_one();
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -74,10 +74,14 @@ void ThreadPool::doWork() {`
`74`	`74`
`75`	`75`	`task = workQueue.front();`
`76`	`76`	`workQueue.pop();`
	`77`	`+ ++busy;`
`77`	`78`	`}`
`78`		`- ++busy;`
`79`	`79`	`task();`
`80`		`- --busy;`
	`80`	`+ {`
	`81`	`+ std::lock_guard<std::mutex> g(workQueueMutex);`
	`82`	`+ --busy;`
	`83`	`+ }`
	`84`	`+ workQueueConditionVariable.notify_one();`
`81`	`85`	`}`
`82`	`86`	`}`
`83`	`87`