130 Add IsAbstract on DataTypes#137
Merged
Merged
Conversation
It was determined that IsAbstract as false was added to any ExpandedNodeId value.
Tests required.
JimLuth
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensured IsAbstract is handled throughout the system
Interesting observation:
RecreateAttributeInstance in the engine will create inherited attributes, when in the case of IsAbstract, it is undesireable. This has substantial consequences for most attributes in the system.
A Local RecreateAttributeInstance was created to remove unwanted inherited attributes. This is only used in a couple of places so far, as the use of RecreateAttributeInstance is widespread. All tests pass as expected, so the solution is assumed to be sufficient