Skip to content

Commit 3b3804c

Browse files
committed
feat: Add comment/document rule checks to review-resolve verification branches
1 parent 279398d commit 3b3804c

1 file changed

Lines changed: 13 additions & 3 deletions

File tree

.claude/skills/review-resolve/SKILL.md

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,22 +79,31 @@ Use the **Write tool** for the file. Bash cat heredoc is unusable because apostr
7979

8080
## Step 2 — Verify Each Finding
8181

82+
### Common Additional Checks for All Verification Branches
83+
84+
For the code-verification branches below (`Status: 🟢 Fixed` is present / `Triage: 🚫 Won't Fix` is present / `Estimate: 🔻 Downgrade` is present), perform the following additional checks immediately before rendering the verdict. The step **Run the common additional checks** inside each branch refers back to here.
85+
86+
- If comments were added or changed, verify that they do not violate the rules in `.claude/rules/comment.md` (auto-loaded). If they do, treat as Feedback.
87+
- If human-facing documentation (README, API reference, etc.; AI-facing prompts under `.claude/` are out of scope) was added or changed, verify that it does not violate the rules in `.claude/rules/document.md` (auto-loaded). If it does, treat as Feedback.
88+
8289
### `Status: 🟢 Fixed` is present
8390

8491
1. Read the referenced files and lines.
8592
2. Confirm that the recorded fix is actually present in the code.
8693
- **When Estimate is `▶️ Maintain`:** Confirm that a regular fix (including logic changes) addressing the finding is reflected and that it fully addresses the original problem.
8794
- **When Estimate is `🚧 Alternative`:** Confirm that an appropriate `FIXME:` / `TODO:` comment has been added at the relevant location. Also check that the comment wording roughly matches the FIXME direction recorded in Estimate and carries enough information for a future fix. Logic changes are not expected.
8895
3. Confirm that the fix has not introduced new issues (regressions, new bugs, style violations, thread safety problems, resource leaks, etc.).
89-
4. Verdict:
96+
4. **Run the common additional checks**.
97+
5. Verdict:
9098
- **Resolved** — The fix is correct, complete, and introduces no new issues.
9199
- **Feedback** — The fix is missing, incomplete, or introduces a new issue. Describe what remains.
92100

93101
### `Triage: 🚫 Won't Fix` is present
94102

95103
1. Read the referenced files and review the current state.
96104
2. Evaluate whether the "won't fix" rationale still holds against the current code.
97-
3. Verdict:
105+
3. **Run the common additional checks**.
106+
4. Verdict:
98107
- **Resolved** — The rationale is valid and the decision is appropriate.
99108
- **Feedback** — The rationale is flawed or the situation has changed. Explain why.
100109

@@ -103,7 +112,8 @@ Use the **Write tool** for the file. Bash cat heredoc is unusable because apostr
103112
1. Read the referenced files and review the current state.
104113
2. Evaluate whether the Estimate's downgrade rationale (spread signals, Cost, Future, decision reason) still holds against the current code.
105114
3. If a separate-PR recommendation is included at the end of the value, confirm that this judgment is appropriate (be especially careful for Critical / Major findings without a separate-PR recommendation).
106-
4. Verdict:
115+
4. **Run the common additional checks**.
116+
5. Verdict:
107117
- **Resolved** — The downgrade rationale is valid.
108118
- **Feedback** — The downgrade rationale is flawed or the situation has changed. Explain why.
109119

0 commit comments

Comments
 (0)