Commit f258953
committed
fix: Drop stage classification from review-resolve analyze.md
The _skip suffix in analyze.md and verify.md had inverted semantics. In review-respond's triage.md, _skip stages (wontfix_skip / downgrade_skip / fixed_skip) are correctly skipped from triage. In review-resolve's analyze.md, the same names were applied even though verify.md treats those stages as the *primary* verification targets. The LLM, reading the same _skip suffix, occasionally interpreted them as "skip from output" semantics, dropping Status: 🟢 Fixed findings out of by_assignee with empty assignee.
by_stage was never actually used downstream: SKILL.md / verify.md / compile.md never reference stage names (compile categorizes by outcome; verify branches on the trailing field). by_assignee dispatch also doesn't use stage names.
Drop stage classification from analyze.md entirely and pin its responsibility to "determine assignee per finding". triage.md (review-respond) is left as-is since stage classification there is essential to its pending_triage / feedback branch logic.
- analyze.md: remove the 7-rule stage classification, drop by_stage from the return value, add explicit "include all findings in by_assignee regardless of METADATA marker state", and pin the final fallback to cpp-sensei when Reviewers is empty.
- SKILL.md: update the Step 1 return-value spec from {total, by_stage, by_assignee, template_id} to {total, by_assignee, template_id}.1 parent b645bc4 commit f258953
2 files changed
Lines changed: 6 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | 110 | | |
111 | 111 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
| 9 | + | |
20 | 10 | | |
21 | 11 | | |
22 | 12 | | |
23 | 13 | | |
24 | | - | |
| 14 | + | |
25 | 15 | | |
26 | | - | |
| 16 | + | |
0 commit comments